Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet component needs fixes for better usability #592

Closed
vuhuucuong opened this issue Mar 11, 2020 · 0 comments · Fixed by #612
Closed

Spreadsheet component needs fixes for better usability #592

vuhuucuong opened this issue Mar 11, 2020 · 0 comments · Fixed by #612
Assignees
Labels
elements Relates to Elements components and utilities enhancements Relates to a feature enhancement front-end Relates to front end issues

Comments

@vuhuucuong
Copy link
Contributor

Summary:

Currently, the afterDataChanged callback props in Spreadsheet is being called EVERY TIME data is changed, including the first time render(data changed from [[]] to initialData). This is okay for most general use cases.

But in our use cases:

  • Data changed -> Call Mutation update in afterDataChanged -> receive the updated data from server -> setData back into Spreadsheet -> Mutation update in afterDataChanged will be called again -> this create an infinity loop.

Task:

Add an afterCellsChanged callback props that will only be called in these cases:

  • When the input value of a Cell changed
  • When right click-> Clear row/Clear column/Remove row/Remove column
  • When CustomComponent value change (e.g when <select> a new value)
  • setData calls will not trigger afterCellsChanged
@vuhuucuong vuhuucuong added elements Relates to Elements components and utilities enhancements Relates to a feature enhancement front-end Relates to front end issues labels Mar 11, 2020
@vuhuucuong vuhuucuong self-assigned this Mar 11, 2020
vuhuucuong pushed a commit that referenced this issue Mar 13, 2020
vuhuucuong pushed a commit that referenced this issue Mar 13, 2020
fix: #592 Spreadsheet fixes for better usability
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
fix: #592 Spreadsheet fixes for better usability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elements Relates to Elements components and utilities enhancements Relates to a feature enhancement front-end Relates to front end issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant