Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate existing Google Map component to new Web Component project #560

Closed
willmcvay opened this issue Mar 9, 2020 · 0 comments
Closed

Migrate existing Google Map component to new Web Component project #560

willmcvay opened this issue Mar 9, 2020 · 0 comments
Assignees
@willmcvay
Labels
feature New feature or request front-end Relates to front end issues web-components
Milestone
Web Components - ...

Comments

@willmcvay
Copy link
Contributor

Depends on #559

  • Web components now written in Svelte so will need to be as lightweight as possible.
  • Will need to roll our own map wrapper.
  • Component will subscribe to Svelte store and plot all properties / selected property on map as before
  • Most of the React-Code can be re-purposed.
  • Need to import and expand tests.
@willmcvay willmcvay added feature New feature or request web-components front-end Relates to front end issues labels Mar 9, 2020
@willmcvay willmcvay added this to the Web Components v1.0 milestone Mar 9, 2020
@trankhacvy trankhacvy self-assigned this Mar 11, 2020
@willmcvay willmcvay assigned willmcvay and unassigned trankhacvy Mar 24, 2020
willmcvay pushed a commit that referenced this issue Mar 25, 2020
@trankhacvy @willmcvay
feat: #560 Google Map Web component
76d9840
willmcvay pushed a commit that referenced this issue Mar 25, 2020
@trankhacvy @willmcvay
feat: #560 add marker window info
539a453
willmcvay pushed a commit that referenced this issue Mar 25, 2020
@trankhacvy @willmcvay
feat: #560 add test cases
d0664b1
willmcvay pushed a commit that referenced this issue Mar 25, 2020
@trankhacvy @willmcvay
feat: #560 Add marker and window info component
6ed6007
trankhacvy added a commit that referenced this issue Mar 25, 2020
@trankhacvy
feat: #560 Add more test cases for map-hepler
097a80d
trankhacvy added a commit that referenced this issue Mar 26, 2020
@trankhacvy
feat: #560 google map web component (#622)
50a8162 
* feat: Create Google Map web component
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@trankhacvy
feat: #560 google map web component (#622)
0404e72 
* feat: Create Google Map web component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmcvay willmcvay

Labels
feature New feature or request front-end Relates to front end issues web-components
Projects
None yet
Milestone
Web Components - Prototype
Development

No branches or pull requests
2 participants
@willmcvay @trankhacvy