Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required to LTL app due to Backend changes #49

Closed
HollyJoyPhillips opened this issue Jan 22, 2020 · 4 comments · Fixed by #216, #223 or #237
Closed

Update required to LTL app due to Backend changes #49

HollyJoyPhillips opened this issue Jan 22, 2020 · 4 comments · Fixed by #216, #223 or #237
Assignees
@duong-se
Labels
bug Something isn't working front-end Relates to front end issues lifetime-legal Relates to Lifetime Legal App
Milestone
Foundations Alpha...

Comments

@HollyJoyPhillips
Copy link
Contributor

HollyJoyPhillips commented Jan 22, 2020 •
edited by willmcvay
Loading

Location: https://dev.lifetime-legal-app.reapit.com/

Summary: The backend team have made changes to the /Contact endpoint which will require updates to the LTL App.

IMPORTANT See comment for details of code fixes

Contact Service

Communication

  • Previously the communication object contained ‘homephone’, ‘workphone’, ‘mobilephone’ and ‘email ‘
  • These are now separate fields so we will need to update the frontend to reflect this

Previous Setup:
image

New setup:
image

Addresses

  • Previously the Primary (0) and Secondary (1) addresses were contained within the object ‘addresses’. They are now separate fields ‘primaryAddress’ & ‘secondaryAddress’.
  • Primary and Secondary Addresses are used in the ‘Address History’ section on both AML and LTL.

Previous setup:
image

identityCheck service:

  • Previously the documents for the primary and secondary ID were contained in the object ‘documents’ and were listed as 0 and 1.
  • Following the changes, they are now separate fields ‘document1’ and ‘document2’. We will need to update ‘AML and LTL’ primary and secondary id sections to reflect this.

Previous:
image

New:
image
@HollyJoyPhillips HollyJoyPhillips added bug Something isn't working ltl labels Jan 22, 2020
duong-se pushed a commit that referenced this issue Jan 22, 2020
@willmcvay
Merge pull request #49 from reapit/fix/select-identity-component
b55654d 
FIX loading on select identity component
willmcvay pushed a commit that referenced this issue Jan 23, 2020
@zlatanpham @willmcvay
fix unable to render multiple modals (#49)
280f6fc
willmcvay added a commit that referenced this issue Jan 24, 2020
@willmcvay
Merge pull request #49 from reapit/feature/CLD-291-style-tweaks
735210e 
[CLD-291] A few width tweaks
@willmcvay
Copy link
Contributor

To make the build pass for mono-repo integration, have had to add ts-ignore to the breaking changes.
For the dev working on this, just grep // @ts-ignore #49 Breaking changes to API and you will see all the places the project is broken.

willmcvay added a commit that referenced this issue Jan 24, 2020
@willmcvay @duong-se
[CLD-309] Upgrades elements to fix menu in mobile (#49)
9a99e3e 
* [CLD-309] Upgrades elements to fix menu in mobile

* [CLD-309] Removes redundant code, fixes a test
willmcvay pushed a commit that referenced this issue Jan 24, 2020
[CLD-238]Table component (#49)
973699e
@HollyJoyPhillips HollyJoyPhillips added lifetime-legal Relates to Lifetime Legal App and removed ltl labels Jan 28, 2020
@duong-se duong-se self-assigned this Jan 30, 2020
@duong-se
Copy link
Contributor

@HollyJoyPhillips I think it'll be effect AML checklist as well, so are there any ticket for AML checklist ?

@HollyJoyPhillips
Copy link
Contributor Author

@tanphamhaiduong Cuong already completed the changes required for AML in the last sprint

@duong-se
Copy link
Contributor

Moving back to TODO because blocked by permission of the app to access contact services

@phmngocnghia phmngocnghia mentioned this issue Jan 31, 2020
Merged
@duong-se duong-se mentioned this issue Feb 10, 2020
Merged
@HollyJoyPhillips HollyJoyPhillips added the front-end Relates to front end issues label Feb 10, 2020
willmcvay pushed a commit that referenced this issue Feb 10, 2020
@duong-se @willmcvay
fix: #49 update backend change for lifetime legal app
23dba28
willmcvay added a commit that referenced this issue Feb 10, 2020
@duong-se @willmcvay
fix: #49 update backend change for lifetime legal (#216)
c0cbd66 
* fix: #49 update backend change for lifetime legal app

* fix: merged together AML & LTL fixes

Co-authored-by: Will McVay <[email protected]>
@duong-se duong-se mentioned this issue Feb 11, 2020
Merged
duong-se added a commit that referenced this issue Feb 11, 2020
@duong-se
fix: #49 update backend change for lifetime legal app
10b095c
duong-se added a commit that referenced this issue Feb 11, 2020
@duong-se
fix: #49 update backend change for lifetime legal app (#223)
46bdce7
duong-se added a commit that referenced this issue Feb 11, 2020
@duong-se
fix: #49 break change on aml checklist and lifetime legal
f790667
@duong-se duong-se mentioned this issue Feb 11, 2020
Merged
willmcvay pushed a commit that referenced this issue Feb 11, 2020
@duong-se
fix: #49 break change on aml checklist and lifetime legal (#237)
3e515f2 
* fix: #49 break change on aml checklist and lifetime legal

* fix: pipeline error on demo site
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@duong-se @willmcvay
fix: #49 update backend change for lifetime legal (#216)
6a08ad2 
* fix: #49 update backend change for lifetime legal app

* fix: merged together AML & LTL fixes

Co-authored-by: Will McVay <[email protected]>
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@duong-se
fix: #49 update backend change for lifetime legal app (#223)
dc789a7
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@duong-se
fix: #49 break change on aml checklist and lifetime legal (#237)
a827105 
* fix: #49 break change on aml checklist and lifetime legal

* fix: pipeline error on demo site
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duong-se duong-se

Labels
bug Something isn't working front-end Relates to front end issues lifetime-legal Relates to Lifetime Legal App
Projects
None yet
Milestone
Foundations Alpha Developer Release
3 participants
@willmcvay @duong-se @HollyJoyPhillips