Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with TypeScript 3.8.2 when scaffolding an app #427

Closed
willmcvay opened this issue Feb 24, 2020 · 0 comments · Fixed by #434
Closed

Issue with TypeScript 3.8.2 when scaffolding an app #427

willmcvay opened this issue Feb 24, 2020 · 0 comments · Fixed by #434
Assignees
@nphivu414
Labels
bug Something isn't working front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package
Milestone
Foundations Beta ...

Comments

@willmcvay
Copy link
Contributor

Steps to replicate:

  • yo @reapit/react-app-scaffolder with latest generator installed globally see: https://foundations-documentation.reapit.cloud/developer-portal#3-register-an-app
  • Select redux and sass
  • Post install, see screenshot, TS not loading
  • Likely an incompatability issue between ts-loader and TypeScript versions.
  • If I look in the node_modules, I can see 3.8.2 gets installed however, 3.7.2 is requested.
  • If I revert to 3.7.2 exact, works fine

Solution: upgrade to 3.8.2 and libs that are failing if possible. If not, ensure 3.7.2 exact is installed.
Screenshot 2020-02-24 at 12 09 44
@willmcvay willmcvay added bug Something isn't working react-app-scaffolder Relates to React App Scaffolder package front-end Relates to front end issues labels Feb 24, 2020
@phmngocnghia phmngocnghia self-assigned this Feb 25, 2020
@nphivu414 nphivu414 assigned nphivu414 and unassigned phmngocnghia Feb 25, 2020
nphivu414 added a commit that referenced this issue Feb 25, 2020
@nphivu414
fix: #427 - Fix ts version to resolve conflicts with tsloader
364e4d7
@nphivu414 nphivu414 linked a pull request Feb 25, 2020 that will close this issue
fix: #427 - Fix ts version to resolve conflicts with tsloader #434
Merged
nphivu414 added a commit that referenced this issue Feb 25, 2020
@nphivu414
fix: #427 - Fix ts version to resolve conflicts with tsloader (#434)
9fe785d
nphivu414 added a commit that referenced this issue Feb 25, 2020
@nphivu414
fix: #427 - Pump react scaffoler verion to 0027
a04e200
nphivu414 added a commit that referenced this issue Feb 25, 2020
@nphivu414
Fix/427 typescript v382 issue with tsloader (#436)
4663ce0 
* fix: #427 - Fix ts version to resolve conflicts with tsloader

* fix: #427 - Pump react scaffoler verion to 0027
nphivu414 added a commit that referenced this issue Apr 29, 2020
@nphivu414
fix: #427 - Fix ts version to resolve conflicts with tsloader (#434)
e0fc6fc
nphivu414 added a commit that referenced this issue Apr 29, 2020
@nphivu414
Fix/427 typescript v382 issue with tsloader (#436)
2709f87 
* fix: #427 - Fix ts version to resolve conflicts with tsloader

* fix: #427 - Pump react scaffoler verion to 0027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphivu414 nphivu414

Labels
bug Something isn't working front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Milestone
Foundations Beta Developer Release
Development

Successfully merging a pull request may close this issue.

fix: #427 - Fix ts version to resolve conflicts with tsloader reapit/foundations
3 participants
@willmcvay @nphivu414 @phmngocnghia