Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file size validation on AML #3942

Closed
HollyJoyPhillips opened this issue Apr 12, 2021 · 2 comments · Fixed by #3945 or #3952
Closed

Add file size validation on AML #3942

HollyJoyPhillips opened this issue Apr 12, 2021 · 2 comments · Fixed by #3945 or #3952
Assignees
@willmcvay
Labels
aml-checklist Relates to Anti-money laundering app bug Something isn't working front-end Relates to front end issues investigate A task for research / gather information task

Comments

@HollyJoyPhillips
Copy link
Contributor

Summary: Currently, AML allows files to be upload that exceed the file limit (on or around 3.2mb) although do not allow the user to proceed (next/save disabled).

Task: Investigate the option to validate the file size after uploading or provide a textual indication of the file size limit (will need to validate it's at 3.2mb.

image

To replicate:
Upload a file larger that 3.2 mb.
@HollyJoyPhillips HollyJoyPhillips added aml-checklist Relates to Anti-money laundering app front-end Relates to front end issues investigate A task for research / gather information labels Apr 12, 2021
@willmcvay willmcvay added the bug Something isn't working label Apr 13, 2021
willmcvay added a commit that referenced this issue Apr 13, 2021
@willmcvay
fix: #3689 #3928 #3942 aml and dev portal fixes
0990681
@willmcvay willmcvay mentioned this issue Apr 13, 2021
Merged
willmcvay added a commit that referenced this issue Apr 13, 2021
@willmcvay
fix: #3689 #3928 #3942 aml and dev portal fixes (#3945)
ef91689
@willmcvay willmcvay self-assigned this Apr 13, 2021
@HollyJoyPhillips
Copy link
Contributor Author

@willmcvay The next/save buttons are now enabled but it's not patching the fileData or the name if the file is too large:

See 3.2mb
image

See 3.9mb
image

willmcvay added a commit that referenced this issue Apr 13, 2021
@willmcvay
fix: #3942 aml file size bug
9d5147d
@willmcvay willmcvay mentioned this issue Apr 13, 2021
Merged
willmcvay added a commit that referenced this issue Apr 13, 2021
@willmcvay
fix: #3942 aml file size bug (#3952)
1e05d9f
@willmcvay
Copy link
Contributor

Have added a validation in the end - seems there is a file size limit on the gateway

@willmcvay willmcvay added the task label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmcvay willmcvay

Labels
aml-checklist Relates to Anti-money laundering app bug Something isn't working front-end Relates to front end issues investigate A task for research / gather information task
Projects
None yet
Milestone
No milestone
2 participants
@willmcvay @HollyJoyPhillips