Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation pages should be styled to look like elements. #2612

Closed
willmcvay opened this issue Sep 8, 2020 · 5 comments · Fixed by #2672
Closed

The documentation pages should be styled to look like elements. #2612

willmcvay opened this issue Sep 8, 2020 · 5 comments · Fixed by #2672
Labels
elements Relates to Elements components and utilities feature New feature or request front-end Relates to front end issues
Milestone

Comments

@willmcvay
Copy link
Contributor

Background

Elements UI library is being refactored to ensure better DX, UX and a more lightweight, flexible library with a more consistent API

Task

  • See specification here: https://github.com/reapit/foundations/blob/master/packages/elements-next/src/index.mdx
  • The docs app should use the same fonts, sizing, spacing and have the same general look and feel as the rest of Elements
  • Borders should be the same, links should be correct Reapit blue, background containers the same white on pale grey effect as our apps.
  • Padding, line breaks and overflow should be fixed for the rendered component output section - see below

Screenshot 2020-09-08 at 12 43 27

@willmcvay willmcvay added feature New feature or request elements Relates to Elements components and utilities front-end Relates to front end issues labels Sep 8, 2020
@willmcvay willmcvay added this to the Elements v2.0 milestone Sep 8, 2020
@phmngocnghia phmngocnghia self-assigned this Sep 9, 2020
@phmngocnghia
Copy link
Contributor

Hi @willmcvay

The docs app should use the same fonts, sizing, spacing and have the same general look and feel as the rest of Elements
Would you like the text of the documentation page to look like elements storybook config, header?

Could you explain the ticket in a more detail way please?

@phmngocnghia phmngocnghia removed their assignment Sep 9, 2020
@willmcvay
Copy link
Contributor Author

@phmngocnghia Elements is a Styleguide. I want to use this styleguide to style the documentation page.

@nphivu414
Copy link
Contributor

Hi @willmcvay , @tanphamhaiduong
As we decided to use StoryBook V6 for Elements V2, I need to re-work on this issue.

@willmcvay
Copy link
Contributor Author

Who decided this @nphivu414 @tanphamhaiduong and why?

nphivu414 pushed a commit that referenced this issue Sep 15, 2020
@duong-se
Copy link
Contributor

@willmcvay actually I see the issue here doczjs/docz#1442. So that is the reason why I move to the storybook. The docz library I think there's no maintainer for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elements Relates to Elements components and utilities feature New feature or request front-end Relates to front end issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants