Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Developers] Should let developer invite one user only 1 time #2535

Closed
duong-se opened this issue Aug 31, 2020 · 3 comments · Fixed by #2646
Closed

[Developers] Should let developer invite one user only 1 time #2535

duong-se opened this issue Aug 31, 2020 · 3 comments · Fixed by #2646
Assignees
@vuhuucuong
Labels
developer-portal feature New feature or request front-end Relates to front end issues
Milestone
Marketplace Web E...

Comments

@duong-se
Copy link
Contributor

Pre-condition: the user had accepted the invitation from a developer
Steps to reproduce:

  1. Go to the developer's site as a developer
  2. Go to the "Organisation" page from "Settings" tab in navigation's menu
  3. Scroll to "Members" part and click on "Invite new member" button, invite the user from pre-condition
  4. Observe Results:

Actual Result: Developer can send the invitation to the user had accepted one invitation

Uploading image.png…

Expected Result: Should let developer invite one user only 1 time
@duong-se duong-se added feature New feature or request front-end Relates to front end issues developer-portal labels Aug 31, 2020
@phmngocnghia phmngocnghia self-assigned this Sep 8, 2020
@willmcvay
Copy link
Contributor

The solution is to filter in the front end so that each invite is only shown once.

  • If the user is active, or pending, don't show any previous invites
  • Only filter out multiple instances of pending and deactivated invites

@phmngocnghia phmngocnghia removed their assignment Sep 8, 2020
@HollyJoyPhillips
Copy link
Contributor

This is good to go

@vuhuucuong vuhuucuong self-assigned this Sep 9, 2020
vuhuucuong pushed a commit that referenced this issue Sep 9, 2020
fix: #2535 filter invite to show only once
c1ff3ea
@vuhuucuong vuhuucuong mentioned this issue Sep 9, 2020
Merged
14 tasks
vuhuucuong pushed a commit that referenced this issue Sep 9, 2020
fix: #2535 add more priority
8165bb8
vuhuucuong pushed a commit that referenced this issue Sep 10, 2020
fix: #2535 Filter invite to show only once per email (#2646)
4889a00
@HollyJoyPhillips
Copy link
Contributor

FYI waiting for platform update (#2656) before completing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuhuucuong vuhuucuong

Labels
developer-portal feature New feature or request front-end Relates to front end issues
Projects
None yet
Milestone
Marketplace Web Enhancements
Development

Successfully merging a pull request may close this issue.

fix: #2535 Filter invite to show only once per email reapit/foundations
5 participants
@willmcvay @duong-se @vuhuucuong @phmngocnghia @HollyJoyPhillips