Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Redirect and Sign Out URIs fields and move the Authentication Flow section #240

Closed
cbryanreapit opened this issue Feb 11, 2020 · 0 comments · Fixed by #283
Closed

Disable Redirect and Sign Out URIs fields and move the Authentication Flow section #240

cbryanreapit opened this issue Feb 11, 2020 · 0 comments · Fixed by #283
Assignees
@vuhuucuong
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues marketplace Relates to the Marketplace
Milestone
Foundations Alpha...

Comments

@cbryanreapit
Copy link
Contributor

cbryanreapit commented Feb 11, 2020 •
edited by HollyJoyPhillips
Loading

Summary: Redirect URIs and Sign Out URIs are not required when 'Client Credentials' has been selected as the Authentication Flow on the 'Submit' app page in the Developers Portal. Therefore we need to disable these fields and re position the 'Authentication Flow' section above those fields.

Task: To move the 'Authentication Flow' section above the 'Redirect URI(s)' & 'Sign Out URI(s) fields and move underneath Summary and Description

See mock up:
AuthFlowClientCreds

Task: To disable the 'Redirect URI(s)' & 'Sign Out URI(s) fields if 'Client Credentials' has been selected from the 'Authentication Flow'

  • Should disable the two fields and make obvious they are disabled by changing the field background colour
  • Should remove from validation requirements
  • Should ensure they are still disabled when editing an app

See mock up:
DisabledClientCred
@cbryanreapit cbryanreapit added bug Something isn't working front-end Relates to front end issues labels Feb 11, 2020
@HollyJoyPhillips HollyJoyPhillips changed the title App registration captures unnecessary fields for client secret (machine to machine) apps Disable Redirect and Sign Out URIs fields and move the Authentication Flow section Feb 13, 2020
@HollyJoyPhillips HollyJoyPhillips added the marketplace Relates to the Marketplace label Feb 13, 2020
@vuhuucuong vuhuucuong self-assigned this Feb 13, 2020
@willmcvay willmcvay added enhancements Relates to a feature enhancement and removed bug Something isn't working labels Feb 13, 2020
@vuhuucuong vuhuucuong mentioned this issue Feb 14, 2020
Merged
vuhuucuong added a commit that referenced this issue Feb 14, 2020
@vuhuucuong
fix: #240 Disable redirect uri, signout uri when auth = clientcredential
4987ea7
vuhuucuong added a commit that referenced this issue Feb 14, 2020
@vuhuucuong
fix: #240 update snapshot due to changes in elements
7575bc3
vuhuucuong added a commit that referenced this issue Feb 14, 2020
@vuhuucuong
fix: #240 resolve conflict
48a1021
vuhuucuong added a commit that referenced this issue Feb 14, 2020
@vuhuucuong
fix: #240 Disable redirect uri, signout uri when auth = clientcredent…
51f5b84 
…ial (#283)

* fix: #240 Disable redirect uri, signout uri when auth = clientcredential

* fix: #240 update snapshot due to changes in elements

* fix: #240 resolve conflict
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@vuhuucuong
[CLD-589] Increase pop up duration to 10s (#240)
29de233
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@vuhuucuong
fix: #240 Disable redirect uri, signout uri when auth = clientcredent…
3799532 
…ial (#283)

* fix: #240 Disable redirect uri, signout uri when auth = clientcredential

* fix: #240 update snapshot due to changes in elements

* fix: #240 resolve conflict
This was referenced Dec 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuhuucuong vuhuucuong

Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Milestone
Foundations Alpha Developer Release
Development

Successfully merging a pull request may close this issue.

fix: #240 Disable redirect uri, signout uri when auth = clientcredential reapit/foundations
4 participants
@willmcvay @vuhuucuong @cbryanreapit @HollyJoyPhillips