-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal users should be able to filter browse apps by query string #2123
Comments
hi @willmcvay, I have a few questions on this:
so how do we filter featured apps, is it also by
Does it mean when |
@vuhuucuong Yes the featured apps will be filtered by client id too in this instance. Page size, just set to be the length of the list of clientIds. Page number 1 obviously. On clientId - I think it's a required field but not sure, will have to just experiment. I think it will work either way but will just have to see. Let me know if you hit a problem |
Hi @vuhuucuong Thanks for putting this together, looks good. Just one small thing, the main apps are duplicating: |
Background context or User story:
Internal users want to be able to filter the browse apps page to get a preview of the marketplace. To do this we will apply a query string to the browse apps page and filter by a list of client ids
Specification or Acceptance Criteria:
?preview=true
if present, don't perform the normal fetch and instead fetch apps from a client id whitelist.ExternalAppId[]
The text was updated successfully, but these errors were encountered: