Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal users should be able to filter browse apps by query string #2123

Closed
willmcvay opened this issue Jul 21, 2020 · 3 comments · Fixed by #2167
Closed

Internal users should be able to filter browse apps by query string #2123

willmcvay opened this issue Jul 21, 2020 · 3 comments · Fixed by #2167
Assignees
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

Internal users want to be able to filter the browse apps page to get a preview of the marketplace. To do this we will apply a query string to the browse apps page and filter by a list of client ids

Specification or Acceptance Criteria:

  • Query string should be ?preview=true if present, don't perform the normal fetch and instead fetch apps from a client id whitelist.
  • List of clientIds to be supplied by @HollyJoyPhillips
  • List of featured apps also to be filtered, again to be supplied by @HollyJoyPhillips
  • Client id lists should be hardcoded or supplied via Reapit Config
  • API supports a list of clientIds as a filter https://dev.platformmarketplace.reapit.net/swagger/index.html called ExternalAppId[]
  • Should render the returned featured and apps list as normal
  • All other filters (isListed for example), to be removed so all expected results are returned
@willmcvay willmcvay added feature New feature or request marketplace Relates to the Marketplace front-end Relates to front end issues labels Jul 21, 2020
@vuhuucuong vuhuucuong self-assigned this Jul 22, 2020
vuhuucuong pushed a commit that referenced this issue Jul 22, 2020
@vuhuucuong
Copy link
Contributor

hi @willmcvay, I have a few questions on this:

List of featured apps also to be filtered

so how do we filter featured apps, is it also by clientIds too, or by some other fields like developerName?

All other filters (isListed for example), to be removed so all expected results are returned

Does it mean when ?preview=true, we only send API with some basic fields like pageSize, pageNumber and ExternalAppId and remove all other fields, do we need to pass in ClientId field in here?
image

@willmcvay
Copy link
Contributor Author

@vuhuucuong Yes the featured apps will be filtered by client id too in this instance.

Page size, just set to be the length of the list of clientIds. Page number 1 obviously.

On clientId - I think it's a required field but not sure, will have to just experiment. I think it will work either way but will just have to see. Let me know if you hit a problem

vuhuucuong pushed a commit that referenced this issue Jul 23, 2020
vuhuucuong pushed a commit that referenced this issue Jul 23, 2020
vuhuucuong pushed a commit that referenced this issue Jul 23, 2020
vuhuucuong pushed a commit that referenced this issue Jul 23, 2020
vuhuucuong pushed a commit that referenced this issue Jul 23, 2020
vuhuucuong pushed a commit that referenced this issue Jul 23, 2020
vuhuucuong pushed a commit that referenced this issue Jul 24, 2020
vuhuucuong pushed a commit that referenced this issue Jul 24, 2020
vuhuucuong pushed a commit that referenced this issue Jul 24, 2020
vuhuucuong pushed a commit that referenced this issue Jul 24, 2020
@HollyJoyPhillips
Copy link
Contributor

Hi @vuhuucuong Thanks for putting this together, looks good. Just one small thing, the main apps are duplicating:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants