Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new styles and containers to AML App #1892

Closed
willmcvay opened this issue Jun 30, 2020 · 0 comments · Fixed by #1972
Closed

Apply new styles and containers to AML App #1892

willmcvay opened this issue Jun 30, 2020 · 0 comments · Fixed by #1972
Assignees
@ant066
Labels
aml-checklist Relates to Anti-money laundering app enhancements Relates to a feature enhancement front-end Relates to front end issues
Milestone
Marketplace Web P...

Comments

@willmcvay
Copy link
Contributor

willmcvay commented Jun 30, 2020 •
edited
Loading

Background context or User story:

See #1805 & #1869 New styles applied to Marketplace should be applied to other apps - this task is to apply to AML App

Specification or Acceptance Criteria:

  • Flex containers replaced with sections. Main app container
  • Ensure 16px rem base is applied and does not break layouts
  • Apply helper to change rem base to 14px when in desktop
  • Ensure Menu is showing and is in grey styles when in desktop
  • Remove as much custom CSS as possible in favour of Elements
  • Ensure styles not broken by removal of !important helpers
  • Replace vertical styling containers with helpers
  • Ensure main headings are H3s and inner headings H5
  • Add Content tags for body text
  • Ensure Roboto is only font and delete Museo Sans
@willmcvay willmcvay added feature New feature or request front-end Relates to front end issues needs-triage labels Jun 30, 2020
@willmcvay willmcvay changed the title Apply new styles and containers to Geo Diary App Apply new styles and containers to AML App Jun 30, 2020
@willmcvay willmcvay added enhancements Relates to a feature enhancement aml-checklist Relates to Anti-money laundering app and removed feature New feature or request needs-triage labels Jun 30, 2020
@ant066 ant066 self-assigned this Jul 1, 2020
@ant066 ant066 mentioned this issue Jul 6, 2020
Merged
14 tasks
ant066 pushed a commit that referenced this issue Jul 6, 2020
refactor: #1892 Apply new styles and containers to AML App (#1972)
f9fd8ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ant066 ant066

Labels
aml-checklist Relates to Anti-money laundering app enhancements Relates to a feature enhancement front-end Relates to front end issues
Projects
None yet
Milestone
Marketplace Web Production Release
Development

Successfully merging a pull request may close this issue.

refactor: #1892 Apply new styles and containers to AML App reapit/foundations
2 participants
@willmcvay @ant066