Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new styles and containers to Geo Diary App #1891

Closed
willmcvay opened this issue Jun 30, 2020 · 1 comment · Fixed by #1976 or #2015
Closed

Apply new styles and containers to Geo Diary App #1891

willmcvay opened this issue Jun 30, 2020 · 1 comment · Fixed by #1976 or #2015
Assignees
@nphivu414
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues geo-diary Relates to GEO Diary app
Milestone
Marketplace Web P...

Comments

@willmcvay
Copy link
Contributor

willmcvay commented Jun 30, 2020 •
edited
Loading

Background context or User story:

See #1805 & #1869 New styles applied to Marketplace should be applied to other apps - this task is to apply to Geo Diary

Specification or Acceptance Criteria:

  • Flex containers replaced with sections. Main app container
  • Ensure 16px rem base is applied and does not break layouts
  • Apply helper to change rem base to 14px when in desktop
  • Ensure Menu is showing and is in grey styles when in desktop
  • Remove as much custom CSS as possible in favour of Elements
  • Ensure styles not broken by removal of !important helpers
  • Replace vertical styling containers with helpers
  • Ensure main headings are H3s and inner headings H5
  • Add Content tags for body text
  • Ensure Roboto is only font and delete Museo Sans
@willmcvay willmcvay added geo-diary Relates to GEO Diary app enhancements Relates to a feature enhancement front-end Relates to front end issues labels Jun 30, 2020
@nphivu414 nphivu414 self-assigned this Jul 1, 2020
nphivu414 pushed a commit that referenced this issue Jul 1, 2020
refactor: #1891 Update Geo Diary styles
d696b32
nphivu414 pushed a commit that referenced this issue Jul 6, 2020
refactor: #1891 Apply new styles for geo diary app
692c465
nphivu414 pushed a commit that referenced this issue Jul 6, 2020
refactor: #1891 Apply 14px fontsize for desktop mode
acfa39c
@nphivu414 nphivu414 mentioned this issue Jul 6, 2020
Merged
14 tasks
nphivu414 pushed a commit that referenced this issue Jul 6, 2020
refactor: #1891 Remove font files for Museo
981c936
nphivu414 pushed a commit that referenced this issue Jul 7, 2020
refactor: #1891 Apply new styles and containers to geo diary app (#1976)
e888130 
* refactor: #1891 Update Geo Diary styles
@HollyJoyPhillips
Copy link
Contributor

Hi @nphivu414 just a couple of small things:

Can you change the background colour to # F5F7F9 (still showing as the old # EEF3F9)
Is it possible to increase the size of the container as the buttons need spacing and when the 'ETA' is present it moves it onto another line:
image
image

nphivu414 pushed a commit that referenced this issue Jul 9, 2020
refactor: #1891 Fix conflicts with master
6cc54c2
nphivu414 pushed a commit that referenced this issue Jul 9, 2020
refactor: #1891 Update Appointment List styles
90c8da0
@nphivu414 nphivu414 mentioned this issue Jul 9, 2020
Merged
14 tasks
duong-se pushed a commit that referenced this issue Jul 9, 2020
refactor: #1891 apply new styles and containers to geo diary app (#2015)
7a8b24c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphivu414 nphivu414

Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues geo-diary Relates to GEO Diary app
Projects
None yet
Milestone
Marketplace Web Production Release
3 participants
@willmcvay @nphivu414 @HollyJoyPhillips