Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Description field #1160

Closed
HollyJoyPhillips opened this issue May 6, 2020 · 6 comments · Fixed by #1181, #1194, #1227 or #1247
Closed

HTML Description field #1160

HollyJoyPhillips opened this issue May 6, 2020 · 6 comments · Fixed by #1181, #1194, #1227 or #1247
Assignees
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues high-priority Issues scheduled for upcoming major release marketplace Relates to the Marketplace

Comments

@HollyJoyPhillips
Copy link
Contributor

Summary: As we have introduced the ability to edit the Description with HTML, we need to address the following issues

Relates to ticket: #1123

  • Can we make the box the same size as the Summary:
    image

  • Adding an external link seems to include the code ‘&nbsp:’

  • The bullet point seems to be out of the green area and not aligned in the revisions modal
    image

  • Or after saving:

image

  • The external link does not work on the modal, when you click it nothing happens:
    image

  • The link should also be the Reapit blue (#0061a8)

  • We need to be able to view the link in the Admin Portal when a revision is made, might need to be a separate ticket?

  • I can’t edit the external link when editing the app, I would have thought highlighting the wording and clicking on the ‘link’ icon would give me the option to edit the existing link

image

  • The line break/paragraph tag doesn’t seem to work at all.

image

@HollyJoyPhillips HollyJoyPhillips added marketplace Relates to the Marketplace enhancements Relates to a feature enhancement front-end Relates to front end issues labels May 6, 2020
@willmcvay willmcvay added the high-priority Issues scheduled for upcoming major release label May 7, 2020
@vuhuucuong vuhuucuong self-assigned this May 7, 2020
vuhuucuong pushed a commit that referenced this issue May 11, 2020
vuhuucuong pushed a commit that referenced this issue May 11, 2020
@vuhuucuong
Copy link
Contributor

vuhuucuong commented May 11, 2020

hi @HollyJoyPhillips , about this

We need to be able to view the link in the Admin Portal when a revision is made, might need to be a separate ticket?

Now we can just click into the link in the revision modal to check where it's linked to. But if you want to somehow view the link without click into it. I think a popup like this pic
Screen Shot 2020-05-11 at 15 33 48
when hovering on the link should be suitable for this, or if you have any idea, that's great.
Please create a new ticket if you want to. Thanks :)

@HollyJoyPhillips
Copy link
Contributor Author

Hey @vuhuucuong That's a great idea. I'll get a ticket added for it, thank you.

vuhuucuong pushed a commit that referenced this issue May 11, 2020
vuhuucuong pushed a commit that referenced this issue May 11, 2020
vuhuucuong pushed a commit that referenced this issue May 11, 2020
vuhuucuong pushed a commit that referenced this issue May 11, 2020
* fix #1160 WIP fixing <Editor> and <HTMLRender>

* fix #1160 fixing <Editor> and <HTMLRender>

* fix: #1160 rem instead of em
@HollyJoyPhillips
Copy link
Contributor Author

Hey @vuhuucuong, thanks for looking at this, just a couple of points:

The placeholder text on the Description is very light, makes it hard to read, can we match the colour with the summary placeholder text
image

I still cannot edit an existing link, can only create a new one?

@vuhuucuong
Copy link
Contributor

vuhuucuong commented May 11, 2020

Thank @HollyJoyPhillips, It's weird if you cant edit existing link, I'm able to do it. As you can see in the below video, I changed the link from github.com to another link

https://streamable.com/fkgij5

About the color, I'll fix it

vuhuucuong pushed a commit that referenced this issue May 12, 2020
vuhuucuong pushed a commit that referenced this issue May 12, 2020
* fix: #1160 fix placeholder color

* fix: #1160 change h6 to h5 in desciption
@HollyJoyPhillips
Copy link
Contributor Author

Hi @vuhuucuong, thanks for updating the font and adding the H5, much better.

Just one small thing, the validation is no longer appearing underneath box if the char limit has not been met or exceed. It is still appearing at the bottom of the page but we should still show it under the field (as we do with the summary)

image

image

@HollyJoyPhillips
Copy link
Contributor Author

Hi @vuhuucuong, it looks like there maybe an issue with the char limit. I've entered 678 chars in the example below, all plain text and it's showing the validation error:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues high-priority Issues scheduled for upcoming major release marketplace Relates to the Marketplace
Projects
None yet
3 participants