Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates required to the Webhooks page in the Developers Portal #1159

Closed
HollyJoyPhillips opened this issue May 6, 2020 · 4 comments · Fixed by #1169 or #1236
Closed

Updates required to the Webhooks page in the Developers Portal #1159

HollyJoyPhillips opened this issue May 6, 2020 · 4 comments · Fixed by #1169 or #1236
Assignees
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@HollyJoyPhillips
Copy link
Contributor

Summary: As we now have the Webhook page with the Add and Edit functionality, there are a few features and UI tweaks that need looking at.

Location: https://dev.marketplace.reapit.cloud/developer/webhooks

  • Remove the option to Add a New Webhook' and the table headers until an app has been selected:
    image

  • Remove the requirement to add a customer as if no customers are added it should apply ‘All Customers’ by default:
    image

  • When editing 'GEO Diary' web hooks 'DXX' is displaying multiple times:
    image

  • If I select ‘DXX’ as a customer, it displays as ‘All Customers’ rather than DXX on the table:
    image

  • Can we use the Topic ‘Name’ rather than the ‘ID’ for the Topic column please?

  • image
    image

  • Can you stack the Topics rather than side by side in the Topic column:
    image

@HollyJoyPhillips HollyJoyPhillips added marketplace Relates to the Marketplace enhancements Relates to a feature enhancement front-end Relates to front end issues labels May 6, 2020
@HollyJoyPhillips HollyJoyPhillips added this to the Web Hooks Dashboard milestone May 6, 2020
@ant066 ant066 self-assigned this May 7, 2020
@ant066
Copy link
Contributor

ant066 commented May 7, 2020

Hi @HollyJoyPhillips.
When editing 'GEO Diary' webhooks 'DXX' is displaying multiple times:
when I call API to get app's installation, it returns many multiple times DXX client.
Screen Shot 2020-05-07 at 10 21 17 AM
So I think this issue about API data.

curl 'https://dev.platformmarketplace.reapit.cloud/installations?AppId=42c60301-c2c5-49bb-b4ec-d5cb27eaf2a4'
-H 'authority: dev.platformmarketplace.reapit.cloud'
-H 'dnt: 1'
-H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.129 Safari/537.36'
-H 'x-api-key: QGUz1hI2ye9VMohQdssOu6N2klb7OetWx5rRAIfh'
-H 'content-type: application/json'
-H 'accept: /'
-H 'origin: http://localhost:8080'
-H 'sec-fetch-site: cross-site'
-H 'sec-fetch-mode: cors'
-H 'sec-fetch-dest: empty'
-H 'referer: http://localhost:8080/developer/webhooks'
-H 'accept-language: vi-VN,vi;q=0.9,fr-FR;q=0.8,fr;q=0.7,en-US;q=0.6,en;q=0.5'
--compressed

@HollyJoyPhillips
Copy link
Contributor Author

@ant066 So it looks like we are calling the Installations endpoint for all installations not just the current installation. DXX has installed and uninstalled GEO Diary on several occasions which is why it is appearing multiple times. It should only show current installations.

If you look on the Analytics page you will see we display GEO Diary as having 2 current installations:
image

You can use the same query to display the customer ID's.

We should only display current installations (where an installation does not have a 'terminated' date). Does that make sense?

ant066 pushed a commit that referenced this issue May 7, 2020
ant066 pushed a commit that referenced this issue May 8, 2020
ant066 pushed a commit that referenced this issue May 8, 2020
…ortal (#1169)

* feat: #1159 Updates required to Webhooks page in the Developers Portal

* chore: #1159 update webhook table render

* chore: #1159 update reducer loading, add call api func as a service

* chore: #1159 update route dispatcher webhook
@HollyJoyPhillips
Copy link
Contributor Author

Hi @ant066, thanks for the update, just a couple of tweaks:

Please remove the table headings when first landing on the page:
image

The modal isn't scrollable when changing the screen size, which means i cannot see the CTA buttons.
image

ant066 pushed a commit that referenced this issue May 11, 2020
ant066 pushed a commit that referenced this issue May 12, 2020
@HollyJoyPhillips
Copy link
Contributor Author

Hi @ant066, can we please add validation to the URL field. If I enter an incorrect URL the backend reports the following 'The value must be a valid and secure URI' can we display that in the frontend please?

image

Please also update the placeholder text from 'Enter a URL' to 'Enter a secure URL (https://)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Relates to a feature enhancement front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
2 participants