Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The web components themes should be served over a CDN #1150

Closed
willmcvay opened this issue May 5, 2020 · 0 comments
Closed

The web components themes should be served over a CDN #1150

willmcvay opened this issue May 5, 2020 · 0 comments
Assignees
@trankhacvy
Labels
demo-site enhancements Relates to a feature enhancement front-end Relates to front end issues web-components
Milestone
Web Components - ...

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

Currently the theme objects that serve the web components are copy pasted into the demo site index.html. This means we have to maintain themes in two places and we can't use them in the new site builder

Specification or Acceptance Criteria:

  • The themes should be pushed to the web components CDN at build time.
  • We should be able to do a commit in web components themes and see the change reflected in demo site without deploying.
@willmcvay willmcvay added demo-site web-components enhancements Relates to a feature enhancement front-end Relates to front end issues labels May 5, 2020
@trankhacvy trankhacvy self-assigned this May 5, 2020
trankhacvy added a commit that referenced this issue May 6, 2020
@trankhacvy
feat: #1150 Served web component themes over CDN
87f859b
trankhacvy added a commit that referenced this issue May 6, 2020
@trankhacvy
feat: #1150 Served web component themes over CDN
2e70cab
trankhacvy added a commit that referenced this issue May 6, 2020
@trankhacvy
feat: #1150 Served web component themes over CDN
de12b14
trankhacvy added a commit that referenced this issue May 8, 2020
@trankhacvy
feat: #1150 Served web component themes over CDN
e6255a1
trankhacvy added a commit that referenced this issue May 8, 2020
@trankhacvy
feat: #1150 Served web component themes over CDN (#1158)
403e4cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trankhacvy trankhacvy

Labels
demo-site enhancements Relates to a feature enhancement front-end Relates to front end issues web-components
Projects
None yet
Milestone
Web Components - Alpha Launch
Development

No branches or pull requests
2 participants
@willmcvay @trankhacvy