Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move payload from query string to post body #10612

Closed
joshbalfour opened this issue Jan 22, 2024 · 0 comments · Fixed by #11011 or #11051
Closed

Move payload from query string to post body #10612

joshbalfour opened this issue Jan 22, 2024 · 0 comments · Fixed by #11011 or #11051
Assignees
@bashleigh
Labels
connect-session front-end Relates to front end issues

Comments

@joshbalfour
Copy link
Contributor

joshbalfour commented Jan 22, 2024 •
edited by plittlewood-rpt
Loading

Background context or User story:
To be more correct to the methods being used, when connect-session makes requests to the token endpoint, we should pass the request parameters in the body (since it's a POST) not in the query string parameters. Cognito does support this.

Specification or Acceptance Criteria:
@joshbalfour joshbalfour added front-end Relates to front end issues connect-session labels Jan 22, 2024
@bashleigh bashleigh self-assigned this Apr 10, 2024
@bashleigh bashleigh mentioned this issue Apr 10, 2024
Merged
bashleigh added a commit that referenced this issue Apr 15, 2024
@bashleigh
Merge branch 'master' into refactor/#10612-convert-connection-session…
53e245e 
…-token-requests-to-post-body
bashleigh added a commit that referenced this issue Apr 15, 2024
@bashleigh
refactor: #10612 convert connection session token requests to post bo…
cc079ac 
…dy (#11011)

* refactor: changed endpoint submit to post body submit

* fix: corrected condition and payload types

* feat: added payload to fetch method

* fix: corrected payload encoding

* feat: added test for making sure fetch is called with post request with body
@bashleigh bashleigh mentioned this issue Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bashleigh bashleigh

Labels
connect-session front-end Relates to front end issues
Projects
None yet
Milestone
No milestone
2 participants
@joshbalfour @bashleigh