[CLD-673] disable categoryID in revision submit (#248)

reapit · Jan 6, 2020 · b41cf7f · b41cf7f
1 parent 3530ea5
commit b41cf7f
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 5 deletions.
diff --git a/src/sagas/__stubs__/revision-submit.ts b/src/sagas/__stubs__/revision-submit.ts
@@ -2,6 +2,7 @@ import { CreateAppRevisionModel } from '@reapit/foundations-ts-definitions'
 
 export const revisionSubmitStub: { data: CreateAppRevisionModel } = {
   data: {
+    categoryId: '',
     description: 'Lorem ipsum',
     homePage: 'https://reapit.com',
     iconImageUrl: 'https://some-s3-image-url.com',

diff --git a/src/sagas/__tests__/submit-revision.ts b/src/sagas/__tests__/submit-revision.ts
@@ -53,7 +53,7 @@ describe('submit-revision post data', () => {
       url: `${URLS.apps}/${id}/revisions`,
       api: process.env.MARKETPLACE_API_BASE_URL as string,
       method: 'POST',
-      body: updatedData,
+      body: { ...updatedData, categoryId: undefined },
       headers: MARKETPLACE_HEADERS
     })
   )

diff --git a/src/sagas/submit-app.ts b/src/sagas/submit-app.ts
@@ -70,7 +70,7 @@ export const submitApp = function*({ data }: Action<SubmitAppArgs>) {
       screen4ImageUrl: imageUploaderResults[4] ? imageUploaderResults[4].Url : ''
     }
 
-    const stripOutCategoryIfNotChose = {
+    const updatedValuesAfterValidatingCategoryId = {
       ...updatedValues,
       categoryId: categoryId === '' ? undefined : categoryId
     }
@@ -79,7 +79,7 @@ export const submitApp = function*({ data }: Action<SubmitAppArgs>) {
       url: URLS.apps,
       api: process.env.MARKETPLACE_API_BASE_URL as string,
       method: 'POST',
-      body: stripOutCategoryIfNotChose,
+      body: updatedValuesAfterValidatingCategoryId,
       headers: MARKETPLACE_HEADERS
     })
 

diff --git a/src/sagas/submit-revision.ts b/src/sagas/submit-revision.ts
@@ -16,7 +16,17 @@ export const submitRevision = function*({ data }: Action<CreateAppRevisionModel
   // TODO: for this situation we need check the value of imageData
   // upload and also update into imageUrl as new property from backend
   try {
-    const { id, name, iconImageUrl, screen1ImageUrl, screen2ImageUrl, screen3ImageUrl, screen4ImageUrl, ...body } = data
+    const {
+      id,
+      name,
+      iconImageUrl,
+      screen1ImageUrl,
+      screen2ImageUrl,
+      screen3ImageUrl,
+      screen4ImageUrl,
+      categoryId,
+      ...body
+    } = data
 
     const formatedName = name ? name.replace(/\s+/g, '-') : ''
     const imageUploaderReqs = [
@@ -38,11 +48,16 @@ export const submitRevision = function*({ data }: Action<CreateAppRevisionModel
       name
     }
 
+    const updatedValuesAfterValidatingCategoryId = {
+      ...updatedValues,
+      categoryId: categoryId === '' ? undefined : categoryId
+    }
+
     const regResponse: true | undefined = yield call(fetcher, {
       url: `${URLS.apps}/${id}/revisions`,
       api: process.env.MARKETPLACE_API_BASE_URL as string,
       method: 'POST',
-      body: updatedValues,
+      body: updatedValuesAfterValidatingCategoryId,
       headers: MARKETPLACE_HEADERS
     })