Skip to content

Commit

Permalink
fix: #1171 pagnination rps issue (#1187)
Browse files Browse the repository at this point in the history
  • Loading branch information
Cuong Vu authored May 11, 2020
1 parent 71913c7 commit 1568f52
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exports[`AppList should match a snapshot 1`] = `
Title
</Component>
<Component
className=" "
className="undefined "
data-test="app-list-container"
>
<Component
Expand Down Expand Up @@ -97,7 +97,7 @@ exports[`AppList should match a snapshot when use empty infoType 1`] = `
Title
</Component>
<Component
className=" "
className="undefined "
data-test="app-list-container"
>
<Component
Expand Down
5 changes: 4 additions & 1 deletion packages/marketplace/src/components/ui/app-list.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ export const AppList: React.FunctionComponent<AppListProps> = ({
: 'We are unable to find any Apps that match your search criteria. Please try again.'}
</Helper>
) : (
<GridFourCol className={` ${loading ? styles.contentIsLoading : ''}`} data-test="app-list-container">
<GridFourCol
className={`${styles.flexGrow} ${loading ? styles.contentIsLoading : ''}`}
data-test="app-list-container"
>
{list.map(app => (
<WrapperContainer key={app.id}>
<AppCard
Expand Down
9 changes: 7 additions & 2 deletions packages/marketplace/src/styles/blocks/app-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
margin-bottom: 1.5rem;
}

.loader-container {
.loaderContainer {
position: absolute;
left: 0;
right: 0;
Expand All @@ -14,6 +14,11 @@
align-items: center;
}

.content-is-loading {
.contentIsLoading {
opacity: 0.75;
}

// to fix old chrome/safari flex-box bug
.flexGrow {
flex: 1 0;
}
2 changes: 1 addition & 1 deletion packages/marketplace/src/tests/badges/badge-branches.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/marketplace/src/tests/badges/badge-lines.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/marketplace/src/tests/badges/badge-statements.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 1568f52

Please sign in to comment.