Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements for the Resource window #1119

Open
StephanRoemer opened this issue Mar 4, 2019 · 10 comments
Open

Several improvements for the Resource window #1119

StephanRoemer opened this issue Mar 4, 2019 · 10 comments

Comments

@StephanRoemer
Copy link

  • The search field does not work as expected. When you enter two key words, the results don't get narrowed down. Sometimes even the opposite is the case and you see more results than with only one keyword.
    https://i.imgur.com/x58Y7J7.gif

In the GIF above, I would have expected that entering "sym" and "soft" would only return the
"SYM Strings Sus Extra Soft" patch.

  • the DEL key has no effect in the search field
  • it would be great if ENTER would jump immediately to the list, so that we can select the track template with the cursor keys.
@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Mar 31, 2019

The search field does not work as expected. When you enter two key words, the results don't get narrowed down. Sometimes even the opposite is the case and you see more results than with only one keyword.

That's because the keywords are OR'ed.
results = keyword1 OR keyword2...

I've added supporting AND keyword (like in Reaper's action list) / plugin list filter), so if you type sym AND soft it should now only show result "SYM Strings Sus Extra Soft".

edit:
see below

@StephanRoemer
Copy link
Author

Thanks nofish, this works as expected! Thanks so much!

Just a little detail: would it be possible to make AND work as default mode (without the need to type it)? That's how the action list works as well. AND is default and if we need OR, we can type it.

@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Apr 1, 2019

Thanks for testing and reporting back.

About making AND default, hm.. I fear someone will complain about changing existing behaviour then. :P
I'll think about it...

@StephanRoemer
Copy link
Author

Hmm maybe you could make it an option (checkbox) to select the default behavior?

@StephanRoemer
Copy link
Author

On the other hand, I can't think of any default behavior where adding several words would result in an OR search. Even the Media Explorer has AND as default. Just as general thought. Maybe it would be more consistent to apply the same behavior to the resources window.

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Apr 2, 2019
Resources: Enter key in filter textbox focuses list
Issue reaper-oss#1119
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Apr 3, 2019
Resources: Enter key in filter textbox focuses list
Issue reaper-oss#1119
@nofishonfriday
Copy link
Collaborator

On the other hand, I can't think of any default behavior where adding several words would result in an OR search. Even the Media Explorer has AND as default. Just as general thought. Maybe it would be more consistent to apply the same behavior to the resources window.

On further thought, agreed. :)
cfillion has a nicely working filter (which I think defaults to AND as should be) implemented in ReaPack, maybe we can reuse that at some point.

@StephanRoemer
Copy link
Author

That would be awesome! :)

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Aug 17, 2019
…m/nofishonfriday/sws into sws-2019-08, PR reaper-oss#1129

* 'filter-textbox-dont-block-del-ley' of https://github.com/nofishonfriday/sws:
  Filter textbox: don't block Del key (Marker list, Track list, Resources) Resources: Enter key in filter textbox focuses list Issue reaper-oss#1119

# Conflicts:
#	whatsnew.txt
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Sep 12, 2019
…m/nofishonfriday/sws into sws-2019-09, PR reaper-oss#1129

* 'filter-textbox-dont-block-del-ley' of https://github.com/nofishonfriday/sws:
  Filter textbox: don't block Del key (Marker list, Track list, Resources) Resources: Enter key in filter textbox focuses list Issue reaper-oss#1119

# Conflicts:
#	whatsnew.txt
@X-Raym
Copy link
Contributor

X-Raym commented Dec 23, 2019

@nofishonfriday Hi ! How this has been implemented ? It is only OR filter for now.

About making AND default, hm.. I fear someone will complain about changing existing behavior then. :P

Actually I'm not sure people will complain. All other reaper fields are AND filters, so it is definitely the expected behavior. 😄 (or at least the expected behavior would been to have working filter with OR keyword support and NOT, like other reaper fields).

@nofishonfriday
Copy link
Collaborator

nofishonfriday commented Dec 23, 2019

@X-Raym
I revised the quoted statement one post later. :P
#1119 (comment)
Agreed with defaulting to AND. :)
Currently it's still only OR though, right (no changes made yet).

@cfillion
What do you think about reusing your ReaPack list filter implementation here?

@cfillion
Copy link
Member

cfillion commented Dec 23, 2019

It depends on the C++11 stdlib so it cannot be used as-is on macOS < 10.7 (it also depends on boost but only for a to_lower function). Porting it to use non-smart pointers should be doable though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants