global: allow operational options in reana.yaml #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase ⏭ |
mvidalgarcia
force-pushed
the
356-toplevel-configurable
branch
from
698fe43 to
d4604b4
Compare
mvidalgarcia
changed the title
mvidalgarcia
force-pushed
the
356-toplevel-configurable
branch
3 times, most recently
from
3a5d2a4 to
3c1bb65
Compare
diegodelemos
reviewed
Apr 3, 2020
| @@ -38,7 +40,7 @@ def workflow_uuid_or_name(ctx, param, value): | |||
| return value | |||
|
|
|||
|
|
|||
| def yadage_load(workflow_file, toplevel='.'): | |||
| def yadage_load(workflow_file, toplevel='.', **kwargs): | |||
There was a problem hiding this comment.
Who is consuming these **kwargs? We already unpack toplevel which is the only one we are interested in.
There was a problem hiding this comment.
If we set other inputs.options such as initdir, its value will get here and this function would fail. With **kwargs we can filter out these options that are not needed on validation time. I agree it's a bit hacky but it's cleanest and safest way I could come up with. If you have any other idea please let me know 🙂
|
|
||
| except ValidationError as e: | ||
| e.message = str(e) | ||
| raise e | ||
|
|
||
|
|
||
| def cwl_load(workflow_file): | ||
| def cwl_load(workflow_file, **kwargs): |
There was a problem hiding this comment.
Same here. For CWL workflows, when passing TARGET: foo for example, it will end up here.
Allows setting workflow engine specific options e.g. `toplevel` for yadage workflows. closes reanahub#356
mvidalgarcia
force-pushed
the
356-toplevel-configurable
branch
2 times, most recently
from
17ac56c to
25125d9
Compare
mvidalgarcia
force-pushed
the
356-toplevel-configurable
branch
5 times, most recently
from
c27c364 to
b7c546c
Compare
This logic is moved to r-w-e-yadage. reanahub/reana-workflow-engine-yadage#150
In favor of `check_output` which is compatible with Python 2.7
mvidalgarcia
force-pushed
the
356-toplevel-configurable
branch
from
773a770 to
e2eb481
Compare
tiborsimko
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #356
reana.yamlcould be like:TODO:
reana.yamloperational options on creation.-o TARGET ...successfully.