Update packaging for Xcode 15.3 #8502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/xcode-15.3
branch
11 times, most recently
from
be142ba to
d584404
Compare
|
Passing release pipeline job with this: https://github.com/realm/realm-swift/actions/runs/8180887917 |
nirinchev
approved these changes
Mar 7, 2024
dianaafanador3
approved these changes
Mar 7, 2024
| @@ -77,6 +77,11 @@ if [[ "$target" == "release-package-build-"* ]]; then | |||
| sed -i '' "s/REALM_HIDE_SYMBOLS = NO;/REALM_HIDE_SYMBOLS = YES;/" "$filename" | |||
| fi | |||
|
|
|||
| # Xcode cloud currently doesn't have visionOS installed for Xcode 15.3 | |||
| if [[ "$CI_WORKFLOW" == release-package-build-vision*_15.3 ]]; then | |||
There was a problem hiding this comment.
From experience this was causing some timeout issues when running the workflow. Is that still the case?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.10 fixed some holes in sendability checking resulting in some new warnings. I fixed most of them in the library itself, but didn't try to fix the ones in the tests.
Xcode cloud no longer allows manually starting a disabled workflow (but reports a 500 server error instead of a useful error), but also fixed the bug where you couldn't actually enable workflows via the api.