Address some memory leaks #8195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemaguire
commented
Mar 30, 2023
| @@ -329,7 +323,7 @@ extension Realm { | |||
|
|
|||
| internal static func fromRLMRealmConfiguration(_ rlmConfiguration: RLMRealmConfiguration) -> Configuration { | |||
| var configuration = Configuration() | |||
| configuration._path = rlmConfiguration.fileURL?.path | |||
There was a problem hiding this comment.
For some strange reason, calling .path showed up as a memory leak in Instruments.
leemaguire
commented
Mar 30, 2023
leemaguire
force-pushed
the
lm/memory-leaks
branch
from
ab36e21 to
7042304
Compare
|
@tgoyne comment addressed. |
tgoyne
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address some memory leak issues a user is having.