Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 Synced file(s) with realm/ci-actions #8091

Merged
merged 9 commits into from
Jan 30, 2023

Conversation

realm-ci
Copy link
Contributor

@realm-ci realm-ci commented Jan 7, 2023

Synced local file(s) with realm/ci-actions.

Changed files
  • Synced local LICENSE with remote synced-files/LICENSE
  • Created local .github/workflows/Issue-Needs-Attention.yml from remote synced-files/.github/workflows/Issue-Needs-Attention.yml
  • Created local .github/workflows/no-response.yml from remote synced-files/.github/workflows/no-response.yml
  • Created local .github/workflows/auto-assign.yml from remote synced-files/.github/workflows/auto-assign.yml
  • Created local .github/auto_assign.yml from remote synced-files/.github/auto_assign.yml
  • Created local .github/advanced-issue-labeler.yml from remote synced-files/.github/advanced-issue-labeler.yml
  • Created local .github/workflows/issue-labeler.yml from remote synced-files/.github/workflows/issue-labeler.yml
  • Created local .github/workflows/check-changelog.yml from remote synced-files/.github/workflows/check-changelog.yml
  • Synced local .github/ISSUE_TEMPLATE/feature.yml with remote synced-files/.github/ISSUE_TEMPLATE/feature.yml

This PR was created automatically by the repo-file-sync-action workflow run #4042772983

@cla-bot cla-bot bot added the cla: yes label Jan 7, 2023
@realm-ci realm-ci force-pushed the repo-sync/ci-actions/default branch from 826a929 to 51f082b Compare January 7, 2023 23:01
@realm-ci realm-ci force-pushed the repo-sync/ci-actions/default branch 6 times, most recently from 36a43e1 to 34fed93 Compare January 8, 2023 21:04
@bmunkholm bmunkholm requested review from jsflax and tgoyne January 26, 2023 18:20
Copy link
Contributor

@dianaafanador3 dianaafanador3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comment. Please review the CodeFactor issues before merging.

- template: [bug.yml, feature.yml]
section:
- id: [frequency]
label:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to know how many users is affecting?, (all, many, just a few or once). I think is a different information than frequency and also can help us prioritise the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if we think that would be useful. Perhaps we can add that as a separate PR?
When i'm thinking about "reach", I'm mostly thinking about if it affect many apps versus many users of a single app. But it's surely relevant.


- id: [app-type]
block-list: []
label:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a RealmSwift context, most of the app don't enter in any of this types. Is this relevant to other SDKs and that's why it is here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is only relevant for .NET. But we use the same common config file. It will have no effect for Swift.

@realm-ci realm-ci force-pushed the repo-sync/ci-actions/default branch 2 times, most recently from 18f315b to 9e1bd18 Compare January 30, 2023 09:58
@realm-ci realm-ci force-pushed the repo-sync/ci-actions/default branch from 9e1bd18 to d889e29 Compare January 30, 2023 10:14
@bmunkholm bmunkholm merged commit 8e10ded into master Jan 30, 2023
@bmunkholm bmunkholm deleted the repo-sync/ci-actions/default branch January 30, 2023 10:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants