Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ObjC Support iteration #7498

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

jsflax
Copy link
Contributor

@jsflax jsflax commented Oct 26, 2021

Fixes #7490.

@jsflax jsflax requested review from tgoyne and leemaguire October 26, 2021 13:44
@cla-bot cla-bot bot added the cla: yes label Oct 26, 2021
@leemaguire
Copy link
Contributor

This needs a changelog entry

@jsflax jsflax requested review from leemaguire and removed request for leemaguire October 27, 2021 12:26
@tgoyne
Copy link
Member

tgoyne commented Oct 27, 2021

This needs tests which actually test that the bug that the user reported is fixed.

@jsflax jsflax requested review from tgoyne and removed request for tgoyne October 27, 2021 16:32
@tgoyne
Copy link
Member

tgoyne commented Oct 28, 2021

There is a whole suite of tests for using the obj-c API from Swift and this should be tested there, not in an unrelated place.

@jsflax
Copy link
Contributor Author

jsflax commented Oct 28, 2021

@tgoyne ptal.

@jsflax jsflax self-assigned this Oct 29, 2021
@jsflax
Copy link
Contributor Author

jsflax commented Oct 29, 2021

Nevermind, seeing some build failures on CI.

@jsflax
Copy link
Contributor Author

jsflax commented Nov 12, 2021

@tgoyne PTAL.

@@ -4,6 +4,9 @@ x.y.z Release notes (yyyy-MM-dd)
* Conform `@ThreadSafe` and `ThreadSafeReference` to `Sendable`.

### Fixed
* Fix `RLMCollectionIterator` where `RLMCollectionIterator` contents were not RLMObject.
This is for users using the optional `RLMSupport.swift` file.
* Change default request timeout for `RLMApp` from 6 seconds to 60 seconds.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad changeset merge.

@stoneyMDB stoneyMDB marked this pull request as draft July 12, 2022 15:23
@lippling
Copy link

What is the status on this? It happens for me as well.

@Bogdan-Belogurov
Copy link

I'm having the same thing over and over again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes when accessing the RLMArray<RLMEmbeddedObject> element
5 participants