Fix crash in RLMSyncConfiguration.initWithUser error mapping when a user is disabled/deleted from MongoDB Realm
#7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsflax
reviewed
Aug 24, 2021
Added a Test for this specific use case, deleting the user using the Admin API |
leemaguire
reviewed
Aug 25, 2021
dianaafanador3
force-pushed
the
dp/fix_error_mapping_rlmsyncconfiguration
branch
from
8c09181 to
7d03ab2
Compare
… user is disabled/deleted from MongoDB Realm dashboard (#7399)
dianaafanador3
force-pushed
the
dp/fix_error_mapping_rlmsyncconfiguration
branch
from
7d03ab2 to
deaf01a
Compare
dianaafanador3
force-pushed
the
dp/fix_error_mapping_rlmsyncconfiguration
branch
from
2bcd1fb to
92b480c
Compare
… user is disabled/deleted from MongoDB Realm dashboard (#7399)
dianaafanador3
force-pushed
the
dp/fix_error_mapping_rlmsyncconfiguration
branch
from
92b480c to
6c2412b
Compare
leemaguire
force-pushed
the
dp/fix_error_mapping_rlmsyncconfiguration
branch
from
6c2412b to
2bcd1fb
Compare
…ithub.com/realm/realm-cocoa into dp/fix_error_mapping_rlmsyncconfiguration # Conflicts: # Realm/ObjectServerTests/SwiftObjectServerTests.swift
leemaguire
reviewed
Sep 8, 2021
|
|
||
| let appServerId = try RealmServer.shared.retrieveAppId(clientAppId: appId) | ||
| let deleteUserEx = expectation(description: "delete-user") | ||
| RealmServer.shared.removeUserForApp(appServerId, userId: app.currentUser!.id) { result in |
There was a problem hiding this comment.
Suggested change
| RealmServer.shared.removeUserForApp(appServerId, userId: app.currentUser!.id) { result in | |
| RealmServer.shared.removeUserForApp(appServerId, userId: user.id) { result in |
Co-authored-by: Lee Maguire <[email protected]>
leemaguire
approved these changes
Sep 8, 2021
…/fix_error_mapping_rlmsyncconfiguration
jsflax
reviewed
Sep 9, 2021
jsflax
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash in
RLMSyncConfiguration.initWithUsererror mapping when a user is disabled/deleted from MongoDB Realm dashboard (#7399)