Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Swift Credentials as an enum #6826

Merged
merged 19 commits into from
Oct 2, 2020
Merged

Define Swift Credentials as an enum #6826

merged 19 commits into from
Oct 2, 2020

Conversation

ejm01
Copy link
Contributor

@ejm01 ejm01 commented Oct 1, 2020

The purpose of this pull request is to define Credentials as an enumerable instead of a typealias of RLMCredentials.

This branch adds an ObjectCSupport.convert for Credentials to RLMCredentials.

tgoyne
tgoyne reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@tgoyne tgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum is short for "enumeration" and not "enumerable", but also should just be written as "enum" even in prose.

RealmSwift/Tests/ObjectiveCSupportTests.swift Outdated Show resolved Hide resolved
RealmSwift/Sync.swift Outdated Show resolved Hide resolved
Realm/ObjectServerTests/SwiftObjectServerTests.swift Outdated Show resolved Hide resolved
jsflax
jsflax reviewed Oct 1, 2020
View reviewed changes
RealmSwift/App.swift Outdated Show resolved Hide resolved
Realm/ObjectServerTests/RLMObjectServerTests.mm Outdated Show resolved Hide resolved
@ejm01
Copy link
Contributor Author

ejm01 commented Oct 1, 2020

I also need to merge in v10 changes before taking out of draft.

@ejm01 ejm01 changed the title Define Swift Credentials as an enumerable Define Swift Credentials as an enum Oct 1, 2020
@ejm01 ejm01 marked this pull request as ready for review October 1, 2020 23:29
@ejm01 ejm01 requested a review from tgoyne October 1, 2020 23:29
@ejm01 ejm01 merged commit 9a9178c into v10 Oct 2, 2020
@ejm01 ejm01 deleted the em/credential-enum branch October 2, 2020 02:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsflax jsflax jsflax approved these changes

@tgoyne tgoyne tgoyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejm01 @tgoyne @jsflax