Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some methods on RLMApp, RLMUser to properties #6825

Merged
merged 5 commits into from
Oct 1, 2020
Merged

Change some methods on RLMApp, RLMUser to properties #6825

merged 5 commits into from
Oct 1, 2020

Conversation

leemaguire
Copy link
Contributor

@leemaguire leemaguire commented Oct 1, 2020 •
edited
Loading

Changes some methods on RLMApp & RLMUser to properties where it sees fit.

@leemaguire leemaguire requested a review from jsflax October 1, 2020 12:59
jsflax
jsflax reviewed Oct 1, 2020
View reviewed changes
Realm/RLMUser.h Outdated Show resolved Hide resolved
@leemaguire leemaguire requested a review from tgoyne October 1, 2020 16:28
@leemaguire leemaguire self-assigned this Oct 1, 2020
@leemaguire leemaguire requested a review from jsflax October 1, 2020 16:28
@leemaguire leemaguire changed the title Make some methods on RLMApp properties Change some methods on RLMApp, RLMUser to properties Oct 1, 2020
tgoyne
tgoyne reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@tgoyne tgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog entries

@leemaguire leemaguire requested a review from tgoyne October 1, 2020 17:35
@leemaguire leemaguire merged commit 3f425d9 into v10 Oct 1, 2020
@leemaguire leemaguire deleted the lm/RLMApp-cleanup branch October 1, 2020 20:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgoyne tgoyne tgoyne approved these changes

@jsflax jsflax Awaiting requested review from jsflax

Assignees

@leemaguire leemaguire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leemaguire @tgoyne @jsflax