Fix a few bugs with frozen objects in obj-c #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How we initialize the schema results in RealmCoordinator's schema cache not containing computed properties, so we need to call set_schema_subset() on frozen Realms to populate them.
jsflax
approved these changes
Jun 10, 2020
| @@ -87,6 +87,39 @@ - (void)testLinkingObjectsOnUnmanagedObject { | |||
| @"Linking objects notifications are only supported on managed objects."); | |||
| } | |||
|
|
|||
| - (void)testLinkingObjectsOnFrozenObject { | |||
| NSArray *(^asArray)(id) = ^(id arrayLike) { | |||
| @@ -1354,7 +1354,7 @@ - (void)testIsFrozen { | |||
| IntObject *frozen = [managed freeze]; | |||
| XCTAssertFalse(standalone.isFrozen); | |||
| XCTAssertFalse(managed.isFrozen); | |||
| XCTAssertFalse(frozen.isFrozen); | |||
There was a problem hiding this comment.
Was this a holdover to get tests passing?
There was a problem hiding this comment.
No, it was just a mistake while writing the test.
| @@ -1017,6 +1017,7 @@ - (RLMRealm *)frozenCopy { | |||
| try { | |||
| RLMRealm *realm = [[RLMRealm alloc] initPrivate]; | |||
| realm->_realm = _realm->freeze(); | |||
| realm->_realm->set_schema_subset(_realm->schema()); | |||
There was a problem hiding this comment.
The commit message says why.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking objects on frozen objects were only tested in Swift and not obj-c, and so unsurprisingly the obj-c version had a dumb bug. -[RLMObject isFrozen] was tested, but the test was wrong. The other change here is just a bit of error checking to give a better error when the user does something that can't work.
Fixes #6568.