-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xcode 11.5 #6526
Merged
Merged
Add Xcode 11.5 #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/xcode-11.5
branch
6 times, most recently
from
May 23, 2020 06:04
44341fb
to
e57e28a
Compare
The first time each Xcode.app directory is touched seems to involve a 30s delay for some reason.
Trying to run the build in parallel with this seems to just make both very slow.
tgoyne
force-pushed
the
tg/xcode-11.5
branch
2 times, most recently
from
May 27, 2020 01:31
2b80e80
to
e3b1068
Compare
Tests which do things on dispatch queues need to wait for the queue to be flushed or sometimes the Realms allocated on those queues will be deallocated after the test tearDown has started.
This speeds up compilation a little and cuts down on i/o a lot.
Since the swift pod depends on the obj-c pod, it would be very difficult for there to ever be a problem which the obj-c test would catch which the swift one will not.
jsflax
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are files here I haven't looked at before, so I need to take a deeper look at those, but looks generally sound.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being a bunch of stuff because either installing Xcode 11.5 or updating to macOS 10.15.4 made the first-launch initialization of the simulators' dyld cache a lot slower, which lead to jobs timing out. To deal with this, I made a pile of adjustments:
I think all of the remaining failures are pre-existing problems now, such as that one of the Combine tests sometimes deadlocks due to a bug in that test. I'll deal with those separately.