Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak on each HTTP request made to ROS #6062

Merged
merged 1 commit into from
Jan 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
x.y.z Release notes (yyyy-MM-dd)
=============================================================
### Enhancements
* None.

### Fixed
* Fix a memory leak whenever Realm makes a HTTP(s) request to the Realm Object
Server (since 3.8.0, Issue [#6058](https://github.com/realm/realm-cocoa/issues/6058)).

### Compatibility
* File format: Generates Realms with format v9 (Reads and upgrades all previous formats)
* Realm Object Server: 3.11.0 or later.
* APIs are backwards compatible with all previous releases in the 3.x.y series.

3.13.1 Release notes (2019-01-03)
=============================================================

Expand Down
2 changes: 2 additions & 0 deletions Realm/RLMNetworkClient.mm
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,8 @@ + (void)sendRequestToEndpoint:(RLMSyncServerEndpoint *)endpoint

// Add the request to a task and start it
[[session dataTaskWithRequest:request] resume];
// Tell the session to destroy itself once it's done with the request
[session finishTasksAndInvalidate];
}
@end

Expand Down