Add support for setting the user agent for sync requests #6007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this does not follow the intended syntax: https://github.com/realm/realm-sync/blob/770e814e7f136950bec9648a0d5c45c1034e9c75/src/realm/sync/client.hpp#L89-L113. Not critical, just mentioning it. |
|
How does it differ? |
Either leave it alone, or read the syntax rules, or tell me if they are not intelligible. |
Should have been |
cmelchior
reviewed
Nov 16, 2018
|
|
Cansel please
Sent from my iPhone Michael lee johnson
… On Nov 16, 2018, at 3:55 PM, Thomas Goyne ***@***.***> wrote:
Should have been (SwiftPermissionsAPITests testClassRead) or ([SwiftPermissionsAPITests testClassRead]) according to syntax suggestion in the docs.
-[SwiftPermissionsAPITests testClassRead] is the name of the application, not additional details.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to write a meaningful test for this as the only actual result is a change in ROS's log output, but I did manually verify that those were updated as expected. An example of the log output with this:
2018-11-16T19:10:36.464Z - info: [sync] Sync Connection[327]: Session[1]: Client info: (path='/testClassRead/__partial/3deca6d376853ed7c14837d89e3194ee/c57d830d4f57760fa30b7ba2d8c1caa2256230af', user='3deca6d376853ed7c14837d89e3194ee', from=[127.0.0.1]:51573, protocol=25) RealmSync/3.13.3 (macOS Darwin 16.7.0 Darwin Kernel Version 16.7.0: Wed Oct 10 20:06:00 PDT 2018; root:xnu-3789.73.24~1/RELEASE_X86_64 x86_64) Realm Swift/3.11.2 -[SwiftPermissionsAPITests testClassRead]
(
-[SwiftPermissionsAPITests testClassRead]is the user-set application identifier, which I set to the test name for testing purposes)Closes #6003.