Add some missing validation to property getters and setters #5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
approved these changes
Oct 9, 2018
|
@tgoyne Was issues reported for this? Then we should list them in the Release note instead of this PR that I added. |
|
No, I noticed it myself while writing some other code. |
6c02999 shifted around where the checks for valid threads and objects were done, and a few turned out to be wrong. This resulted in either crashing within core rather than throwing an exception, or throwing an untranslated C++ exception rather than the appropriate obj-c exception.
tgoyne
force-pushed
the
tg/deleted-object-validation
branch
2 times, most recently
from
59392fa to
ebecc65
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6c02999 shifted around where the checks for valid threads and objects were done, and a few turned out to be wrong. This resulted in either crashing within core rather than throwing an exception, or throwing an untranslated C++ exception rather than the appropriate obj-c exception.
RLMArray and RLMResults already have tests similar to the ones added here.