Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #4534, find xcode without spotlight #4536

Merged
merged 2 commits into from
Jan 18, 2017

Conversation

larkost
Copy link
Contributor

@larkost larkost commented Jan 12, 2017

This avoids using spotlight to find Xcode if it can, avoiding some times when Spotlight has been unreliable on the CO machines. It also solves #4503 by making the selection of Xcode on CI machines deterministic (given identical installs of Xcode).

This avoids using spotlight to find Xcode if it can, avoiding some times when Spotlight has been unreliable on the CO machines. It also solves #4503 by making the selection of Xcode on CI machines deterministic (given identical installs of Xcode).
@larkost larkost self-assigned this Jan 12, 2017
@larkost larkost requested a review from jpsim January 12, 2017 00:56
@jpsim
Copy link
Contributor

jpsim commented Jan 13, 2017

This doesn't seem to have had the intended effect.

image

@larkost
Copy link
Contributor Author

larkost commented Jan 13, 2017

There was a debugging line that got left in, and that turned into the first line in the output when build.sh get-version is called by generate-rlmversion.sh, so was being put into RLMVersion.h.

@jpsim jpsim merged commit 5f521fe into master Jan 18, 2017
@jpsim jpsim deleted the larkost/4534-find-xcode-without-spotlight branch January 18, 2017 20:48
@jpsim jpsim removed the S:Review label Jan 18, 2017
@jpsim
Copy link
Contributor

jpsim commented Jan 18, 2017

Thanks @larkost !

@larkost larkost restored the larkost/4534-find-xcode-without-spotlight branch February 3, 2017 21:45
@larkost larkost deleted the larkost/4534-find-xcode-without-spotlight branch February 14, 2017 19:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants