Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed some TightDB references in the RLMDemo. #209

Merged
merged 1 commit into from
Apr 23, 2014

Conversation

bmunkholm
Copy link
Contributor

@jp: Please review, but I merge right away for the release.

bmunkholm added a commit that referenced this pull request Apr 23, 2014
Renamed some TightDB references in the RLMDemo.
@bmunkholm bmunkholm merged commit ef67011 into master Apr 23, 2014
@jpsim
Copy link
Contributor

jpsim commented Apr 23, 2014

Great changes, clearly. The only thing I don't like (in my original code) is

NSLog(@"%@ is %@", row[@"title"], [(NSNumber *)row[@"checked"] boolValue] ? @"checked" : @"unchecked");

Let's change that to a slightly more readable

BOOL checked = [(NSNumber *)row[@"checked"] boolValue];
NSLog(@"%@ is %@", row[@"title"], checked ? @"checked" : @"unchecked");

This would be prettier with a typed version of find: but that doesn't exist in the API yet :(.

@alazier
Copy link
Contributor

alazier commented Apr 23, 2014

Just to note, once we change the return type from RLMRow * to id you will be able to drop the cast to have BOOL checked = [row[@"checked"] boolValue];

@jpsim
Copy link
Contributor

jpsim commented Apr 23, 2014

For anonymous objects, or id, I still like being explicit and casting it.

@bmunkholm bmunkholm deleted the bm_RLMDemo_renames branch May 8, 2014 11:40
kishikawakatsumi pushed a commit that referenced this pull request Sep 20, 2016
Release 1.0.2-7 with sync 0.28.0
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants