Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterated on how the logs and the context is displayed #761

Merged
merged 3 commits into from
Mar 22, 2018
Merged

Iterated on how the logs and the context is displayed #761

merged 3 commits into from
Mar 22, 2018

Conversation

kraenhansen
Copy link
Member

This fixes #760

skaermbillede 2018-03-21 kl 16 09 39

skaermbillede 2018-03-21 kl 16 09 25

skaermbillede 2018-03-21 kl 16 08 45

fealebenpae
fealebenpae previously approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@fealebenpae fealebenpae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh this looks so much better - I'm going to log all the things.

@kraenhansen kraenhansen force-pushed the kh/prettier-log-messages branch from fec0d49 to 04f0bae Compare March 22, 2018 08:08
@kraenhansen kraenhansen self-assigned this Mar 22, 2018
@kraenhansen
Copy link
Member Author

  • Added icons to the level selector,
  • Increased rendering performance
  • Simplified how we show the most likely case (when service and timestamp is in the context) - we only show the context object if there are more than those two keys.

skaermbillede 2018-03-22 kl 09 16 48

@kraenhansen kraenhansen merged commit d51ff2f into master Mar 22, 2018
@kraenhansen kraenhansen deleted the kh/prettier-log-messages branch March 22, 2018 10:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae left review comments

@cmelchior cmelchior Awaiting requested review from cmelchior

Assignees

@kraenhansen kraenhansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the way ROS logged messages are displayed in Studio
2 participants
@kraenhansen @fealebenpae