Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (realm-browser): Allow select multiples rows and delete all of them #593

Merged
merged 6 commits into from
Mar 23, 2018

Conversation

IvanCoronado
Copy link
Contributor

@IvanCoronado IvanCoronado commented Jan 5, 2018

@kraenhansen Main logic is done and currently, you can select multiples rows and delete them but I am still working on cleaning the code.

multipleselectdelete

@@ -11,6 +11,7 @@
"es5",
"es6"
],
"downlevelIteration": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added again - why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kraenhansen Allow using JS set with TS. The other option is updating the TS target to ES6 here https://github.com/realm/realm-studio/blob/master/tsconfig.json#L3 since we have an electron APP and we don't need to support any other browser.

https://github.com/realm/realm-studio/pull/593/files#diff-9782c73de5279cde9ace9669f0314891R503

@kraenhansen
Copy link
Member

kraenhansen commented Jan 30, 2018

When I select multiple rows, I get some funky behaviour where every row has a cell highlighted from the last column I selected. For example - if I click the businessId 17 and shift click 50 I get this:

skaermbillede 2018-01-30 kl 10 07 34

But if I then shift click "SUSHI ZONE" I get

skaermbillede 2018-01-30 kl 10 08 15

I wouldn't expect the highlight to disappear from the businessId cells or the cells above "SUSHI ZONE" to be highlighted too.

@kraenhansen
Copy link
Member

When altering a selection by removing single rows (cmd + click), the browser scrolls to the row that started the selection. This is really annoying when removing single items from the selection.

multi-selection-scroll

@bigfish24
Copy link
Contributor

@kraenhansen can we get this merged?

Sent with GitHawk

@kraenhansen
Copy link
Member

@bigfish24 I'll take a look at it tomorrow - it needs some TLC as I tried to visualize above.

@kraenhansen kraenhansen force-pushed the ic/delete-multiples-rows branch from fa8509c to 7d7050e Compare March 22, 2018 14:42
@kraenhansen kraenhansen merged commit 055a1b8 into master Mar 23, 2018
@kraenhansen kraenhansen deleted the ic/delete-multiples-rows branch March 23, 2018 15:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants