-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (realm-browser): Allow select multiples rows and delete all of them #593
Conversation
@@ -11,6 +11,7 @@ | |||
"es5", | |||
"es6" | |||
], | |||
"downlevelIteration": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added again - why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kraenhansen Allow using JS set with TS. The other option is updating the TS target to ES6
here https://github.com/realm/realm-studio/blob/master/tsconfig.json#L3 since we have an electron APP and we don't need to support any other browser.
When I select multiple rows, I get some funky behaviour where every row has a cell highlighted from the last column I selected. For example - if I click the businessId 17 and shift click 50 I get this: But if I then shift click "SUSHI ZONE" I get I wouldn't expect the highlight to disappear from the businessId cells or the cells above "SUSHI ZONE" to be highlighted too. |
@kraenhansen can we get this merged? Sent with GitHawk |
@bigfish24 I'll take a look at it tomorrow - it needs some TLC as I tried to visualize above. |
fa8509c
to
7d7050e
Compare
@kraenhansen Main logic is done and currently, you can select multiples rows and delete them but I am still working on cleaning the code.