RSTUDIO-528: Update version to add support for collections in mixed #1651
Conversation
gagik
changed the title
gagik
force-pushed
the
gagik/update-realm-version
branch
from
3589aef to
64dbc34
Compare
| - name: Setup Python 3.11 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.11.x' |
There was a problem hiding this comment.
CI seems to have updated to python 3.12 by default. node-sass is deprecated and was breaking CI lint because one of its dependencies was using a python standard library which was removed in 3.12: nodejs/node-gyp#2869
So we can...
a) stick to Python 3.11, which I am going to do in this PR for this to be as little breaking as possible.
b) get sass (node-sass replacement) working in a different issue/PR, which requires some small changes in our current SASS code which has deprecrated fields.
There was a problem hiding this comment.
Please create an issue for option b)
There was a problem hiding this comment.
I suspect this too is related to macos-latest now being arm64 and missing prebuilds for node-sass starting a build from source.
There was a problem hiding this comment.
@kraenhansen I think it's related in sense that the arm64 might be shipping with a more updated Python version by default but the error I was getting was specifically related to distutils not being in Python 3.12, as seen here: nodejs/node-gyp#2869 rather than binaries
There was a problem hiding this comment.
When installing node-sass on the x86 MacOS runner, it doesn't need Python at all, because it downloads a prebuilt binary instead of building from source (requiring Python when running node-gyp).
There was a problem hiding this comment.
ah, interesting, I assumed it always depended on Python, good to know! Another reason for the new sass as this should be much more compatible from what I have seen.
| - name: Setup Python 3.11 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.11.x' |
There was a problem hiding this comment.
Please create an issue for option b)
Co-authored-by: Kenneth Geisshirt <[email protected]>
Co-authored-by: Kenneth Geisshirt <[email protected]>
No description provided.