This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Removing Adapter and Global Notifier #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsflax
approved these changes
Feb 18, 2020
…tore into kneth/remove-gn-and-adapter
8 tasks
…remove-gn-and-adapter
|
There's some assorted objectstore things which exist purely to support the GN that should be cleaned up too. From memory there's TransactionChangeInfo.track_all and RealmCoordinator::open_with_config(), but I think there may be a few others. shared_realm.hpp also still has a mention of GlobalNotifier. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing adapter and global notifier have implications for some SDKs.