This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Add a missing virtual destructor to CollectionChangeCallback #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in the destructor for the callback object passed to `add_notification_callback()` not being called, potentially resulting in memory leaks when removing notification callbacks.
realm-ci
force-pushed
the
tg/add-missing-virtual-destructor
branch
from
cbf5027 to
98612b9
Compare
|
CI failure was due to that job running on a worker that's out of disk space. |
|
Hey - looks like you forgot to add a T:* label - could you please add one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in the destructor for the callback object passed to
add_notification_callback()not being called, potentially resulting in memory leaks when removing notification callbacks.