This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
ROBJSTORE-98 Implement precise and unbatched notification of sync completion events #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgoyne let me know if you have time to review this. |
tgoyne
approved these changes
Oct 14, 2020
src/sync/sync_session.cpp
Outdated
| SyncSession::CompletionCallbacks callbacks_to_register; | ||
| std::swap(session.m_completion_callbacks, callbacks_to_register); | ||
|
|
||
| for (auto& [ id, callback_tuple ] : callbacks_to_register) { |
There was a problem hiding this comment.
Spacing on structured binding is inconsistent here; some have spaces in [] and some don't. I think no spaces is the normal thing?
src/sync/sync_session.cpp
Outdated
| auto download_handlers = std::move(m_download_completion_callbacks); | ||
| auto upload_handlers = std::move(m_upload_completion_callbacks); | ||
|
|
||
| auto completion_callbacks = std::move(m_completion_callbacks); |
There was a problem hiding this comment.
In the other spots we do this you changed it to swapping with a local which is probably better, so this one should as well.
There was a problem hiding this comment.
Will do. I also added a FIXME comment since I realized advance_state is not exception safe so we should make sure that we always move the callbacks back in place by using a guard type, but I don't think we need to fix that in this PR.
jbreams
force-pushed
the
jbr/ROBJSTORE-98
branch
from
e833e54 to
02bc1c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this in lieu of #1054.