-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IR output verification to sample test #3
Conversation
Hmm. IR output seems to hold machine specific paths. |
...compiler-plugin/compiler-plugin/src/test/kotlin/io/realm/compiler/GenerationExtensionTest.kt
Outdated
Show resolved
Hide resolved
val result = KotlinCompilation().apply { | ||
sources = listOf(SourceFile.fromPath(resource)) | ||
sources = inputs.fileMap.values.map { SourceFile.fromPath(it)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is just me, but when using it
so far down a call chain, I'm not sure at all what it
is? Some entries in a map, but the context is gone
...compiler-plugin/compiler-plugin/src/test/kotlin/io/realm/compiler/GenerationExtensionTest.kt
Outdated
Show resolved
Hide resolved
...compiler-plugin/compiler-plugin/src/test/kotlin/io/realm/compiler/GenerationExtensionTest.kt
Outdated
Show resolved
Hide resolved
...ler-plugin/compiler-plugin/src/test/resources/sample/expected/00_ValidateIrBeforeLowering.ir
Outdated
Show resolved
Hide resolved
@rorbech there's also an |
The kotlin infrastructure around this is quite massive and are not (as far as I can see) easily reusable in our context. My take would just be to merge the simple convention about having |
Just a quick and dirty addition outlining a principle to allow IR output verification