-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Realm Core v13.26.0 #6405
Conversation
The changes seem fine, but I suspect the It also likes like the integration tests error on the removal of users after a particular test
I think it's caused by this line
|
Have you had a chance to look into the crash from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice upgrade! Just have a comment about the base URL changes that would be good to address 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the PR description, but from the Core spec.yml changes it does look like the base URL related changes are also there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My impression is that it should be done later but I might be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see now that base_url
was removed from the App
and not AppConfig
in the spec 👍
It is |
81d6080
to
7e927a1
Compare
I've created #6441 to track fixing the crash 👍 |
* Upgrade to Realm Core v13.26.0 * Use a well-formed URL in test * Update CHANGELOG.md --------- Co-authored-by: Kræn Hansen <[email protected]>
What, How & Why?
This is an upgrade of Realm Core. I have worked around the breaking change related to the implementation of
new Realm.App()
. We might want to discuss if we would like to expose app caching at a later time.The new base URL functionality isn't exposed yet. It will be part of roaming project (yet to be decided).
Moreover,
spec.yml
needed a small update so the upgrade isn't as clean as I would like it.This closes #6403
☑️ ToDos
Compatibility
label is updated or copied from previous entryCOMPATIBILITY.md
package.json
s (if updating internal packages)Breaking
label has been applied or is not necessary