Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling session multiplexing by default #5912

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Enabling session multiplexing by default #5912

merged 3 commits into from
Jun 22, 2023

Conversation

kraenhansen
Copy link
Member

What, How & Why?

With the merge of realm/realm-core#6676 it's now possible to enable session multiplexing by default.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this Jun 20, 2023
@cla-bot cla-bot bot added the cla: yes label Jun 20, 2023
@kraenhansen kraenhansen requested review from kneth and takameyer June 20, 2023 13:32
@coveralls
Copy link

Coverage Status

coverage: 85.663% (+0.004%) from 85.659% when pulling 2b4a133 on kh/session-multiplexing-by-default into f2a8905 on main.

takameyer
takameyer reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment fix. I've noticed there are no docs for this at docs.mongodb.com. Perhaps we should signal this.

packages/realm/src/app-services/App.ts Outdated Show resolved Hide resolved
@kraenhansen
Copy link
Member Author

I'm left wondering why the PR workflow doesn't kick in? 😕

@kraenhansen kraenhansen force-pushed the kh/session-multiplexing-by-default branch from 1dfd6f4 to 5894e1a Compare June 20, 2023 17:18
@kraenhansen kraenhansen merged commit 1c922d0 into main Jun 22, 2023
@kraenhansen kraenhansen deleted the kh/session-multiplexing-by-default branch June 22, 2023 18:27
@Omrisnyk Omrisnyk mentioned this pull request Nov 28, 2023
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kneth kneth kneth approved these changes

@takameyer takameyer takameyer approved these changes

Assignees

@kraenhansen kraenhansen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kraenhansen @coveralls @takameyer @kneth