Default session multiplexing to being disabled #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
approved these changes
May 22, 2023
nhachicha
pushed a commit
that referenced
this pull request
May 23, 2023
papafe
added a commit
that referenced
this pull request
May 24, 2023
* main: Remove incorrect info and adds to return description for compact() (#5798) Use `declare prop` rather than `prop!` with Object.declareProperty() Use Object.defineProperty rather than Object.defineProperties because it is faster Update importAppBefore to take an AppConfiguration (#5838) Adding `next` to install test matrix (#5819) Default session multiplexing to being disabled (#5831) Adding types for some "environment" options Exposing a defaultLogLevel context option Update pr-realm-js.yml Update PR workflow to pin the server version Update baas test server install script
papafe
added a commit
that referenced
this pull request
May 24, 2023
* main: Remove incorrect info and adds to return description for compact() (#5798) Use `declare prop` rather than `prop!` with Object.declareProperty() Use Object.defineProperty rather than Object.defineProperties because it is faster Update importAppBefore to take an AppConfiguration (#5838) Adding `next` to install test matrix (#5819) Default session multiplexing to being disabled (#5831) Adding types for some "environment" options Exposing a defaultLogLevel context option Update pr-realm-js.yml Update PR workflow to pin the server version Update baas test server install script bump realm-core to v13.11.0 (#5814) Hold SyncSessions with a std::weak_ptr, except while calling a method (#5815) Update typescript.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This fix the immediate issue crashing our test suite. I'll follow up with a PR introducing the use of session multiplexing to consistently provoke a crash.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary