Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SubscriptionsState in favor of SubscriptionSetState #5774

Merged
merged 2 commits into from
May 4, 2023
Merged

Deprecate SubscriptionsState in favor of SubscriptionSetState #5774

merged 2 commits into from
May 4, 2023

Conversation

elle-j
Copy link
Contributor

@elle-j elle-j commented Apr 27, 2023 •
edited
Loading

What, How & Why?

Deprecates SubscriptionsState in v12 in favor of SubscriptionSetState to better align with SubscriptionSet.

This closes #5773.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Public documentation PR created

@cla-bot cla-bot bot added the cla: yes label Apr 27, 2023
kneth
kneth approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue tracking the breaking change for v13?

takameyer
takameyer reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Great change

@elle-j elle-j merged commit 174cd31 into main May 4, 2023
@elle-j elle-j deleted the lj/subscription-set-state branch May 4, 2023 10:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takameyer takameyer takameyer approved these changes

@kneth kneth kneth approved these changes

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees

@elle-j elle-j

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate SubscriptionsState in favor of SubscriptionSetState
4 participants
@elle-j @takameyer @kneth @kraenhansen