Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11] Tag early during release #5676

Merged
merged 1 commit into from
Apr 5, 2023
Merged

[v11] Tag early during release #5676

merged 1 commit into from
Apr 5, 2023

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Mar 31, 2023

What, How & Why?

This closes #5674

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated

@cla-bot cla-bot bot added the cla: yes label Mar 31, 2023
@kneth kneth requested review from takameyer and kraenhansen March 31, 2023 15:28
takameyer
takameyer approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kraenhansen kraenhansen merged commit 715fa2d into v11 Apr 5, 2023
@kraenhansen kraenhansen deleted the kneth/v11/gha-tag-release branch April 5, 2023 16:58
@kraenhansen
Copy link
Member

kraenhansen commented Apr 5, 2023 •
edited
Loading

I merged this as I'll be doing a v12 release soon. But I just realised this won't be tested as it's merged against v11.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

@takameyer takameyer takameyer approved these changes

Assignees

@kneth kneth

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kneth @kraenhansen @takameyer