Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install test refactored #5085

Merged
merged 58 commits into from
Nov 10, 2022
Merged

Install test refactored #5085

merged 58 commits into from
Nov 10, 2022

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This refactors the install tests to:

  • Run on both Android and iOS (previously it was just on iOS)
  • Run with the new RN architecture enabled and disabled
  • Run with RN@latest and RN@next (in an attempt to catch bugs early)
  • Run with both jsc and hermes enabled
  • Run at 7AM CET every Monday (to help us prioritise any bug on the upcoming planning meeting)

@kraenhansen kraenhansen self-assigned this Nov 7, 2022
@cla-bot cla-bot bot added the cla: yes label Nov 7, 2022
takameyer
takameyer approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few clarifying questions and suggestions. Nothing holding this back, except that it seems realm-core is being updated?

.github/workflows/install-test-react-native.yml Show resolved Hide resolved
.github/workflows/install-test-react-native.yml Outdated Show resolved Hide resolved
install-tests/react-native/patches/ccache-Podfile.patch Show resolved Hide resolved
install-tests/react-native/cli.ts Outdated Show resolved Hide resolved
@kraenhansen
Refactored the install test
86c8ebd
@kraenhansen
Install CLI deps
ed99191
@kraenhansen
Test android
be56388
@kraenhansen
Improved Slack message
d8e2342
@kraenhansen
Installing and skipping ios on android
bc95d29
@kraenhansen
Update install-test-react-native.yml
b134ad0
@kraenhansen
Update cli.ts
834dae5
@kraenhansen
Update install-test-react-native.yml
5c1feb3
@kraenhansen
Update install-test-react-native.yml
d847833
@kraenhansen
Update install-test-react-native.yml
1243b13
@kraenhansen
Update install-test-react-native.yml
5f6b5f8
@kraenhansen
Update install-test-react-native.yml
1b9bbe2
@kraenhansen
Update install-test-react-native.yml
073fe35
@kraenhansen
Update install-test-react-native.yml
fa9ce37
@kraenhansen
Update install-test-react-native.yml
d89498e
@kraenhansen
Applying a Podfile patch to use ccache
95becd2
@kraenhansen
Configuring ccache
1811545
@kraenhansen
Make ccache key more specific to avoid cross contamination
2875e12
@kraenhansen
Printing timeout in error
805d3fb
@kraenhansen
Announce on Slack only once pr run
2bcfde4
@kraenhansen
Tried downgrading Xcode
a5dde0f
@kraenhansen
Fixed syntax error
b1fbf72
@kraenhansen
Update install-test-react-native.yml
71f3f48
@kraenhansen
Try failing when test fails
ee360d6
@kraenhansen
Copy link
Member Author

kraenhansen commented Nov 8, 2022 •
edited
Loading

realm-core is being updated?

Oh my .. great catch!

kneth
kneth approved these changes Nov 8, 2022
View reviewed changes
install-tests/react-native/cli.ts Outdated Show resolved Hide resolved
kraenhansen and others added 22 commits November 8, 2022 12:03
@kraenhansen
Upload result artifacts
df36fd8
@kraenhansen
Moved App.js into patches
5e9b95b
@kraenhansen
Writing a local.properties for Android
7e68e0b
@kraenhansen
Upload result from install-tests/react-native
32df771
@kraenhansen
Use CLI to generate Slack payload
df6999e
@kraenhansen
Update install-test-react-native.yml
e63554a
@kraenhansen
Assuming location of results
567acaf
@kraenhansen
Renamed command
9a1cfab
@kraenhansen
Resolving and printing output path
6258531
@kraenhansen
Updated upload path
f6a126f
@kraenhansen
Update install-test-react-native.yml
bcc5586
@kraenhansen
Corrected the file path when loading result files
dbcf0c8
@kraenhansen
Update install-test-react-native.yml
3459c55
@kraenhansen
Locating result.json recursively
2d2665e
@kraenhansen
Update install-test-react-native.yml
620750a
@kraenhansen
Update install-test-react-native.yml
def5a39
@kraenhansen
Reverted the custom slack message builder
676d6ef
@kraenhansen
Adding a timeout the the emulator
32084a7
@kraenhansen
Rearranged options
5903eb0
@kraenhansen
Throw instead of calling process.exit
b1e4ee8
@kraenhansen
Remove old script from package.json
91eadbc
@kraenhansen @kneth
Update install-tests/react-native/cli.ts
e6804a1 
Co-authored-by: Kenneth Geisshirt <[email protected]>
@kraenhansen kraenhansen merged commit 684f2b3 into master Nov 10, 2022
@kraenhansen kraenhansen deleted the kh/install-test-refactored branch November 10, 2022 05:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kneth kneth kneth approved these changes

@takameyer takameyer takameyer approved these changes

Assignees

@kraenhansen kraenhansen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kraenhansen @takameyer @kneth