Update clang-format npm package version to match system clangd on newer Macs, and update code style to match #4869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The default
clangd
installed on newer Macs formats empty classes differently. As the system version is used by the VS Code plugin, but the version used for the lint job is fixed (it is packaged in theclang-format
npm package), this results in lint errors if you rely on your editor to format the code on newer Macs.Our config would seem to be setup such that these empty classes should in fact be split but perhaps some new option has been added that we haven't set. Given that it's not a huge deal, and also that the config structure is pretty complex so figuring it out could take a while, I thought the pragmatic solution was to update the
clang-format
package to match the newerclangd
.clangd
version (e.g. via Homebrew and add it to your path) if you are on an older Mac.☑️ ToDos
Compatibility
label is updated or copied from previous entrypackage.json
s (if updating internal packages)Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's: