-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated EmailPasswordAuth functions #4842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
reviewed
Aug 31, 2022
kraenhansen
reviewed
Aug 31, 2022
kraenhansen
reviewed
Aug 31, 2022
takameyer
force-pushed
the
andrew/deprecate-reset-password
branch
from
August 31, 2022 09:11
39ce659
to
c8bab74
Compare
kraenhansen
approved these changes
Aug 31, 2022
takameyer
force-pushed
the
andrew/deprecate-reset-password
branch
from
August 31, 2022 11:09
c8bab74
to
6bbbf57
Compare
takameyer
changed the title
Remove depreacted EmailPasswordAuth functions
Remove deprecated EmailPasswordAuth functions
Aug 31, 2022
takameyer
force-pushed
the
andrew/deprecate-reset-password
branch
from
August 31, 2022 12:51
6bbbf57
to
115cbcf
Compare
kraenhansen
force-pushed
the
v11
branch
6 times, most recently
from
September 13, 2022 07:21
bd551c6
to
bb8ce55
Compare
takameyer
force-pushed
the
andrew/deprecate-reset-password
branch
from
September 13, 2022 07:36
115cbcf
to
a4a7e14
Compare
tomduncalf
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
The positional argument functions have been removed and now only the object arguments are accepted.
takameyer
force-pushed
the
andrew/deprecate-reset-password
branch
from
September 13, 2022 11:21
a4a7e14
to
aec25bf
Compare
takameyer
added a commit
that referenced
this pull request
Sep 14, 2022
) * Remove deprecated EmailPasswordAuth functions (#4842) The positional argument functions have been removed and now only the object arguments are accepted. * Match types for `User#callFunction` implementation across platforms The unifies the call signature of User#callFunction across all documentation and platforms. `callFunction` now has the signature: ```javascript user.callFunction('func', 1, 2, 3); ``` * Update lib/user.js Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
kraenhansen
added a commit
that referenced
this pull request
Sep 15, 2022
) * Remove deprecated EmailPasswordAuth functions (#4842) The positional argument functions have been removed and now only the object arguments are accepted. * Match types for `User#callFunction` implementation across platforms The unifies the call signature of User#callFunction across all documentation and platforms. `callFunction` now has the signature: ```javascript user.callFunction('func', 1, 2, 3); ``` * Update lib/user.js Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
takameyer
added a commit
that referenced
this pull request
Sep 15, 2022
) * Remove deprecated EmailPasswordAuth functions (#4842) The positional argument functions have been removed and now only the object arguments are accepted. * Match types for `User#callFunction` implementation across platforms The unifies the call signature of User#callFunction across all documentation and platforms. `callFunction` now has the signature: ```javascript user.callFunction('func', 1, 2, 3); ``` * Update lib/user.js Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
kraenhansen
added a commit
that referenced
this pull request
Oct 18, 2022
) * Remove deprecated EmailPasswordAuth functions (#4842) The positional argument functions have been removed and now only the object arguments are accepted. * Match types for `User#callFunction` implementation across platforms The unifies the call signature of User#callFunction across all documentation and platforms. `callFunction` now has the signature: ```javascript user.callFunction('func', 1, 2, 3); ``` * Update lib/user.js Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The positional argument functions have been removed and now
only the object arguments are accepted.
☑️ ToDos
Compatibility
label is updated or copied from previous entrypackage.json
s (if updating internal packages)Breaking
label has been applied or is not necessaryIf this PR adds or changes public API's: