Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated EmailPasswordAuth functions #4842

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

takameyer
Copy link
Contributor

What, How & Why?

The positional argument functions have been removed and now
only the object arguments are accepted.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Aug 30, 2022
@takameyer takameyer requested a review from kneth August 30, 2022 14:00
packages/mocha-reporter/dist/index.js Outdated Show resolved Hide resolved
packages/realm-app-importer/src/DeleteAll.ts Outdated Show resolved Hide resolved
@takameyer takameyer force-pushed the andrew/deprecate-reset-password branch from 39ce659 to c8bab74 Compare August 31, 2022 09:11
@takameyer takameyer force-pushed the andrew/deprecate-reset-password branch from c8bab74 to 6bbbf57 Compare August 31, 2022 11:09
@takameyer takameyer changed the title Remove depreacted EmailPasswordAuth functions Remove deprecated EmailPasswordAuth functions Aug 31, 2022
@takameyer takameyer force-pushed the andrew/deprecate-reset-password branch from 6bbbf57 to 115cbcf Compare August 31, 2022 12:51
@kraenhansen kraenhansen force-pushed the v11 branch 6 times, most recently from bd551c6 to bb8ce55 Compare September 13, 2022 07:21
@takameyer takameyer force-pushed the andrew/deprecate-reset-password branch from 115cbcf to a4a7e14 Compare September 13, 2022 07:36
Copy link
Contributor

@tomduncalf tomduncalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
The positional argument functions have been removed and now
only the object arguments are accepted.
@takameyer takameyer force-pushed the andrew/deprecate-reset-password branch from a4a7e14 to aec25bf Compare September 13, 2022 11:21
@takameyer takameyer merged commit 4dcab24 into v11 Sep 13, 2022
@takameyer takameyer deleted the andrew/deprecate-reset-password branch September 13, 2022 12:08
takameyer added a commit that referenced this pull request Sep 14, 2022
)

* Remove deprecated EmailPasswordAuth functions (#4842)

The positional argument functions have been removed and now
only the object arguments are accepted.

* Match types for `User#callFunction` implementation across platforms

The unifies the call signature of User#callFunction across all documentation
and platforms.
`callFunction` now has the signature:
```javascript
  user.callFunction('func', 1, 2, 3);
```

* Update lib/user.js

Co-authored-by: Kræn Hansen <[email protected]>

Co-authored-by: Kræn Hansen <[email protected]>
kraenhansen added a commit that referenced this pull request Sep 15, 2022
)

* Remove deprecated EmailPasswordAuth functions (#4842)

The positional argument functions have been removed and now
only the object arguments are accepted.

* Match types for `User#callFunction` implementation across platforms

The unifies the call signature of User#callFunction across all documentation
and platforms.
`callFunction` now has the signature:
```javascript
  user.callFunction('func', 1, 2, 3);
```

* Update lib/user.js

Co-authored-by: Kræn Hansen <[email protected]>

Co-authored-by: Kræn Hansen <[email protected]>
takameyer added a commit that referenced this pull request Sep 15, 2022
)

* Remove deprecated EmailPasswordAuth functions (#4842)

The positional argument functions have been removed and now
only the object arguments are accepted.

* Match types for `User#callFunction` implementation across platforms

The unifies the call signature of User#callFunction across all documentation
and platforms.
`callFunction` now has the signature:
```javascript
  user.callFunction('func', 1, 2, 3);
```

* Update lib/user.js

Co-authored-by: Kræn Hansen <[email protected]>

Co-authored-by: Kræn Hansen <[email protected]>
kraenhansen added a commit that referenced this pull request Oct 18, 2022
)

* Remove deprecated EmailPasswordAuth functions (#4842)

The positional argument functions have been removed and now
only the object arguments are accepted.

* Match types for `User#callFunction` implementation across platforms

The unifies the call signature of User#callFunction across all documentation
and platforms.
`callFunction` now has the signature:
```javascript
  user.callFunction('func', 1, 2, 3);
```

* Update lib/user.js

Co-authored-by: Kræn Hansen <[email protected]>

Co-authored-by: Kræn Hansen <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants