Fix ccache on M1 #4764
Merged
Fix ccache on M1 #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Aug 10, 2022
scripts/ccache-clang++.sh
Outdated
| export CCACHE_MAXSIZE=10G | ||
| export CCACHE_CPP2=true | ||
| export CCACHE_HARDLINK=true | ||
| export CCACHE_SLOPPINESS=file_macro,time_macros,include_file_mtime,include_file_ctime,file_stat_matches | ||
| exec /usr/local/bin/ccache /usr/bin/clang++ "$@" | ||
| exec ccache /usr/bin/clang++ "$@" |
There was a problem hiding this comment.
Suggested change
| exec ccache /usr/bin/clang++ "$@" | |
| exec ccache clang++ "$@" |
I wonder if clang++ could also just be read from the path?
There was a problem hiding this comment.
As long as it's in the path...which it should be.
kraenhansen
reviewed
Aug 10, 2022
kneth
approved these changes
Aug 10, 2022
Homebrew installs ccache in a different directory on the M1. This checks if ccache exists in the path rather then a specific location.
takameyer
force-pushed
the
andrew/fix-ccache-m1
branch
from
f9b8bdf to
58c87e2
Compare
kraenhansen
approved these changes
Aug 11, 2022
amtep
pushed a commit
to amtep/realm-js
that referenced
this pull request
Aug 11, 2022
Homebrew installs ccache in a different directory on the M1. This checks if ccache exists in the path rather then a specific location.
amtep
pushed a commit
to amtep/realm-js
that referenced
this pull request
Aug 12, 2022
Homebrew installs ccache in a different directory on the M1. This checks if ccache exists in the path rather then a specific location.
amtep
pushed a commit
to amtep/realm-js
that referenced
this pull request
Aug 16, 2022
Homebrew installs ccache in a different directory on the M1. This checks if ccache exists in the path rather then a specific location.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew installs ccache in a different directory on the M1.
This checks if ccache exists in the path rather then a specific location.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: