Add default logger for tests #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomduncalf
force-pushed
the
td/add_default_test_logger
branch
from
69425e9 to
31db0a2
Compare
tomduncalf
force-pushed
the
td/add_default_test_logger
branch
from
31db0a2 to
fceda7a
Compare
takameyer
approved these changes
Jul 15, 2022
The colors are great. Good idea!
kraenhansen
approved these changes
Jul 15, 2022
| @@ -30,6 +32,14 @@ export function importAppBefore( | |||
| } else { | |||
| this.app = await importApp(name, replacements); | |||
| Realm.App.Sync.setLogLevel(this.app, logLevel); | |||
| // Set a default logger as Android does not forward stdout | |||
| Realm.App.Sync.setLogger(this.app, (level, message) => { | |||
| const magentaDate = `\x1b[35m${new Date().toISOString().replace("T", " ").replace("Z", "")}`; | |||
There was a problem hiding this comment.
The full date timestamps feel a bit excessive to me. Perhaps an HH:MM:SS.ms would be enough?
Nit: I'd personally split this in two lines, I don't like debugging expressions inside of template strings (same goes for the line below).
There was a problem hiding this comment.
Yea fair point maybe the data isn't that useful!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This adds a default logger for the integration tests, as we currently get no output on Android as it forwards
stdoutto/dev/null. The log is colourised to help with reading it.☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: